Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winlogbeat: add caching of metadata handles #888

Merged
merged 1 commit into from Feb 1, 2016

Conversation

Projects
None yet
2 participants
@andrewkroh
Copy link
Member

commented Jan 29, 2016

Caching is already part of the eventlogging implementation, but it wasn't yet added to the wineventlog implementation. This gives a performance boost to Winlogbeat.

  • Add caching of event metadata handles (a file handle to a DLL or EXE containing message resources)
  • Reuse a single system render context when rendering events
@ruflin

This comment has been minimized.

Copy link
Collaborator

commented Jan 30, 2016

LGTM. I would suggest to update the CHANGELOG.

@andrewkroh andrewkroh force-pushed the andrewkroh:feature/winlogbeat-caching branch from e4c46cd to c0fc105 Feb 1, 2016

ruflin added a commit that referenced this pull request Feb 1, 2016

Merge pull request #888 from andrewkroh/feature/winlogbeat-caching
Winlogbeat: add caching of metadata handles

@ruflin ruflin merged commit 002fa5d into elastic:master Feb 1, 2016

4 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Merged build finished.
Details

@andrewkroh andrewkroh deleted the andrewkroh:feature/winlogbeat-caching branch Feb 1, 2016

andrewkroh added a commit to andrewkroh/beats that referenced this pull request Mar 3, 2016

Fix an issue with caching from elastic#888.
Add expvar metrics for the cache (hits/misses/size).
Add strict validation for top-level YAML keys in winlogbeat config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.