Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip and status to heartbeat dashboard table #9022

Merged
merged 1 commit into from Nov 26, 2018

Conversation

@andrewvc
Copy link
Contributor

andrewvc commented Nov 9, 2018

The heartbeat dashboard table currently doesn't include these fields by default.
These fields are useful for two reasons:

  1. A given monitor.id often runs against separate IPs which may have different downtime results
  2. Viewing the latest status for a given id/status tuple is a common use case. It answers the question: "what's down?".

Fixes #8972

The heartbeat dashboard table currently doesn't include these fields by default.
These fields are useful for two reasons:

1. A given monitor.id often runs against separate IPs which may have different downtime results
2. Viewing the latest status for a given id/status tuple is a common use case. It answers the question: "what's down?".

Fixes #8972
@andrewvc andrewvc force-pushed the andrewvc:add-status-ip-dash branch from e0f2ef3 to 2780953 Nov 9, 2018
Copy link

dov0211 left a comment

LGTM

@andrewvc

This comment has been minimized.

Copy link
Contributor Author

andrewvc commented Nov 14, 2018

jenkins, retest this please

@andrewvc andrewvc added the :uptime label Nov 26, 2018
@andrewvc andrewvc merged commit b3de5f6 into elastic:master Nov 26, 2018
4 checks passed
4 checks passed
CLA Commit author has signed the CLA
Details
Hound No violations found. Woof!
beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
andrewvc added a commit to andrewvc/beats that referenced this pull request Nov 26, 2018
The heartbeat dashboard table currently doesn't include these fields by default.
These fields are useful for two reasons:

1. A given monitor.id often runs against separate IPs which may have different downtime results
2. Viewing the latest status for a given id/status tuple is a common use case. It answers the question: "what's down?".

Fixes elastic#8972

(cherry picked from commit b3de5f6)
@andrewvc andrewvc added the v6.6.0 label Nov 26, 2018
andrewvc added a commit that referenced this pull request Nov 27, 2018
The heartbeat dashboard table currently doesn't include these fields by default.
These fields are useful for two reasons:

1. A given monitor.id often runs against separate IPs which may have different downtime results
2. Viewing the latest status for a given id/status tuple is a common use case. It answers the question: "what's down?".

Fixes #8972

(cherry picked from commit b3de5f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.