Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to support moved filebeat modules #9432

Merged
merged 7 commits into from Dec 21, 2018

Conversation

@jsoriano
Copy link
Member

jsoriano commented Dec 7, 2018

If a module needs to be moved, existing configuration will stop working,
this change adds an option to mark an old module as moved to other name.

This is being considered for the movement of apache2 module to apache to
be coherent with metricbeat module (#9402).

So if the module.yml file of the apache2 module contains:

movedTo: apache

Every time the apache2 module is used a warning is printed about the
change and apache module is used instead.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

elasticmachine commented Dec 7, 2018

Pinging @elastic/infrastructure

If a module needs to be moved, existing configuration will stop working,
this change adds an option to mark an old module as moved to other name.

This is being considered for the movement of apache2 module to apache to
be coherent with metricbeat module (#9402).
@jsoriano jsoriano force-pushed the jsoriano:filebeat-move-modules branch from be2f921 to 30bc249 Dec 7, 2018
Copy link
Collaborator

ruflin left a comment

Could you add some tests to this PR? Not sure yet what the best way would be here.

@jsoriano

This comment has been minimized.

Copy link
Member Author

jsoriano commented Dec 11, 2018

Test added with a dummy modules directory for this case.

@jsoriano jsoriano removed the needs tests label Dec 11, 2018
@ruflin

This comment has been minimized.

Copy link
Collaborator

ruflin commented Dec 12, 2018

jenkins, test this

@ruflin
ruflin approved these changes Dec 12, 2018
jsoriano added 2 commits Dec 13, 2018
@jsoriano jsoriano requested a review from elastic/beats-contributors as a code owner Dec 20, 2018
@jsoriano jsoriano merged commit 1b83f5e into elastic:master Dec 21, 2018
3 of 5 checks passed
3 of 5 checks passed
beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
CLA Commit author has signed the CLA
Details
Hound No violations found. Woof!
continuous-integration/jenkins/pr-merge This commit looks good
Details
@jsoriano jsoriano deleted the jsoriano:filebeat-move-modules branch Dec 21, 2018
jsoriano added a commit that referenced this pull request Jan 12, 2019
Rename filebeat `apache2` module to `apache`. `apache2` module
is kept as a "moved" module (#9432) so existing configurations continue
working.

Aliases for renamed fields are added and they will be handled as fields
renamed for ECS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.