Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event.dataset to filebeat #9457

Merged
merged 5 commits into from Dec 11, 2018

Conversation

Projects
None yet
4 participants
@ruflin
Copy link
Collaborator

commented Dec 10, 2018

This allows 6.6 / 6.7 data to be compatible with 7.x.

Add event.dataset to filebeat
This allows 6.6 / 6.7 data to be compatible with 7.x.

@ruflin ruflin self-assigned this Dec 10, 2018

@ruflin ruflin referenced this pull request Dec 10, 2018

Closed

Transition Beats to ECS #8655

133 of 136 tasks complete
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Dec 10, 2018

Pinging @elastic/infrastructure

ruflin added some commits Dec 10, 2018

@graphaelli
Copy link
Member

left a comment

any need to enforce that event.dataset is always fileset.module + fileset.name (say with a test)?

@@ -54,7 +55,7 @@
"tags": [
"suricata"
],
"url.hostname": "example.net",
"url.hostname": "example.net",

This comment has been minimized.

Copy link
@graphaelli

graphaelli Dec 11, 2018

Member

bunch of these extra spaces, not sure if you care

This comment has been minimized.

Copy link
@ruflin

ruflin Dec 11, 2018

Author Collaborator

the files are auto generated so more wonder why there were missing before :-)

This comment has been minimized.

Copy link
@webmat

webmat Dec 11, 2018

Contributor

Ah I may have saved it in a commit, before I was familiar with the Beats integration tests :-)

- name: event.dataset
description: >
The Filebeat dataset that generated this event.

This comment has been minimized.

Copy link
@webmat

webmat Dec 11, 2018

Contributor

Nice, so we have per-Beat override 👍

@ruflin

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 11, 2018

@graphaelli Good question about the test. I don't think we should enforce it (event though at the moment it is because it's in the code). More important for me is that it's correct in the generate files. Ok if for now we skip a test?

@graphaelli

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

sounds reasonable to me

@webmat

webmat approved these changes Dec 11, 2018

Copy link
Contributor

left a comment

Straightforward, LGTM.

@ruflin ruflin merged commit 661641c into elastic:6.x Dec 11, 2018

4 checks passed

CLA Commit author has signed the CLA
Details
Hound No violations found. Woof!
beats-ci Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ruflin ruflin deleted the ruflin:add-fileset branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.