Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include Pod UID as part of Pod metadata #9517

Merged
merged 5 commits into from Dec 14, 2018

Conversation

Projects
None yet
4 participants
@exekias
Copy link
Member

commented Dec 12, 2018

We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the drop_fields processor
like this:

processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]

closes #9360

Always include Pod UID as part of Pod metadata
We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the `drop_fields` processor
like this:

```
processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]
```

@exekias exekias force-pushed the exekias:force-pod-uid branch from bfb83be to 812047d Dec 12, 2018

exekias added some commits Dec 12, 2018

@kaiyan-sheng

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2018

Any documentation needs to be updated here?

@exekias

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2018

Yes! thank you for bringing it up, as this was an undocumented feature (intended that way), I have only updated the points where we explain the resulting fields

@elasticmachine

This comment has been minimized.

Copy link

commented Dec 13, 2018

@ruflin

ruflin approved these changes Dec 13, 2018

Copy link
Collaborator

left a comment

LGTM. Ignore the killed OS X build.

@ruflin ruflin self-assigned this Dec 14, 2018

@ruflin ruflin merged commit 571b882 into elastic:master Dec 14, 2018

3 of 4 checks passed

beats-ci Build finished.
Details
CLA Commit author is a member of Elasticsearch
Details
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details

ruflin added a commit to ruflin/beats that referenced this pull request Dec 14, 2018

Always include Pod UID as part of Pod metadata (elastic#9517)
We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the `drop_fields` processor
like this:

```
processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]
```

closes elastic#9360

(cherry picked from commit 571b882)

@ruflin ruflin removed the needs_backport label Dec 14, 2018

ruflin added a commit to ruflin/beats that referenced this pull request Dec 14, 2018

Always include Pod UID as part of Pod metadata (elastic#9517)
We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the `drop_fields` processor
like this:

```
processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]
```

closes elastic#9360

(cherry picked from commit 571b882)

@ruflin ruflin added the v6.5.4 label Dec 14, 2018

ruflin added a commit to ruflin/beats that referenced this pull request Dec 14, 2018

Always include Pod UID as part of Pod metadata (elastic#9517)
We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the `drop_fields` processor
like this:

```
processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]
```

closes elastic#9360

(cherry picked from commit 571b882)

ruflin added a commit that referenced this pull request Dec 17, 2018

Always include Pod UID as part of Pod metadata (#9517) (#9552)
We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the `drop_fields` processor
like this:

```
processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]
```

closes #9360

(cherry picked from commit 571b882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.