Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test reconcile methods #249

Open
pebrc opened this issue Dec 20, 2018 · 1 comment
Open

Test reconcile methods #249

pebrc opened this issue Dec 20, 2018 · 1 comment
Labels
justdoit Continuous improvement not related to a specific feature >test Related to unit/integration/e2e tests

Comments

@pebrc
Copy link
Collaborator

pebrc commented Dec 20, 2018

Most of the reconcile methods are missing tests. Let's change that.
@pebrc pebrc mentioned this issue Dec 20, 2018
Merged
@pebrc pebrc added the justdoit Continuous improvement not related to a specific feature label Feb 8, 2019
@sebgl sebgl added the >test Related to unit/integration/e2e tests label Jul 17, 2019
@barkbay barkbay mentioned this issue Apr 28, 2020
Merged
@barkbay
Copy link
Contributor

barkbay commented Apr 28, 2020

Following up #2975 an important point is that the unit tests should cover the onDelete call, checking that all watchers are cleaned when the resource is deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
justdoit Continuous improvement not related to a specific feature >test Related to unit/integration/e2e tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pebrc @barkbay @sebgl