Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name the webhook service port #2771

Closed
charith-elastic opened this issue Mar 25, 2020 · 0 comments · Fixed by #2829
Closed

Name the webhook service port #2771

charith-elastic opened this issue Mar 25, 2020 · 0 comments · Fixed by #2829
Labels
>enhancement Enhancement of existing functionality good first issue Good for newcomers

Comments

@charith-elastic
Copy link
Contributor

We currently don't name the webhook service port which causes istioctl analyze to complain (see #2770). Although nothing is broken, there's no harm in correctly naming the port to put the users at ease.
@charith-elastic charith-elastic added good first issue Good for newcomers justdoit Continuous improvement not related to a specific feature labels Mar 25, 2020
@botelastic botelastic bot added the triage label Mar 25, 2020
@charith-elastic charith-elastic added the >enhancement Enhancement of existing functionality label Mar 25, 2020
@botelastic botelastic bot removed the triage label Mar 25, 2020
@charith-elastic charith-elastic removed the justdoit Continuous improvement not related to a specific feature label Mar 25, 2020
@slalwani97 slalwani97 mentioned this issue Apr 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement Enhancement of existing functionality good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Name the webhook service port slalwani97/cloud-on-k8s
1 participant
@charith-elastic