[Helm] Unify role bindings - #4262
Merged
charith-elastic merged 2 commits intoFeb 23, 2021
Merged
Conversation
pebrc
approved these changes
Feb 23, 2021
| name: "{{ $fullName }}" | ||
| namespace: {{ $namespace }} | ||
| labels: | ||
| {{- include "eck-operator.labels" $ | nindent 4 }} |
Collaborator
There was a problem hiding this comment.
I think the Selector labels include is missing a - as it produces a leading empty line.
| @@ -0,0 +1,80 @@ | |||
| {{- $operatorNSIsManaged := has .Release.Namespace .Values.managedNamespaces -}} | |||
Collaborator
There was a problem hiding this comment.
bit odd that the file is called role-bindings.yaml but it also contains roles
charith-elastic
added a commit
to charith-elastic/cloud-on-k8s
that referenced
this pull request
Feb 24, 2021
* [Helm] Unify role bindings * Fix space in labels
charith-elastic
added a commit
that referenced
this pull request
Mar 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered a bug that I could swear I fixed a couple of months ago (a missing role binding if the operator namespace is included in the managed namespaces list) 🤷🏼
This PR fixes the bug and also combines the role bindings into a single template. Having them spread over two files made it too difficult to reason about.