From 8c5fbdbb07f164376f49806943f3be87e0c779d6 Mon Sep 17 00:00:00 2001
From: Dominik Giger <dominik.giger@gmail.com>
Date: Wed, 10 Apr 2024 14:21:34 +0200
Subject: [PATCH] Prepare release 1.17.0 (#464)

- Generate changelog
- Switch to Github app token.
  - The original GH_TOKEN doesn't exist anymore, but github automatically provisions a GITHUB_TOKEN
  - The `permissions` entry defines that this token is allowed to write (and therefore create releases)
- Removes the apivalidation workflow: This action has been failing constantly and hasn't been maintained in years.
---
 .changelog/1.17.0/461.yml           |  4 ++--
 .github/workflows/apivalidation.yml | 33 -----------------------------
 .github/workflows/release.yml       |  6 +++---
 notes/v1.17.0.md                    | 18 ++++++++++++++++
 4 files changed, 23 insertions(+), 38 deletions(-)
 delete mode 100644 .github/workflows/apivalidation.yml
 create mode 100644 notes/v1.17.0.md

diff --git a/.changelog/1.17.0/461.yml b/.changelog/1.17.0/461.yml
index cf5bcdc6..9abe5e58 100644
--- a/.changelog/1.17.0/461.yml
+++ b/.changelog/1.17.0/461.yml
@@ -1,8 +1,8 @@
-category: enchancement
+category: enhancement
 title: Update to latest ECE 3.7.0 api
 description: |
   Breaking: 
-   - The notes api is no more. Use the deployment comment api in stead.
+   - The notes api is no more. Use the deployment comment api instead.
   Other: 
    - The instance configurations can now specify allowed zones.
    - The deployment update api can use the ValidateOnly flag
diff --git a/.github/workflows/apivalidation.yml b/.github/workflows/apivalidation.yml
deleted file mode 100644
index d65c3163..00000000
--- a/.github/workflows/apivalidation.yml
+++ /dev/null
@@ -1,33 +0,0 @@
-name: api-validation
-
-on:
-  repository_dispatch:
-    types: api-validation-tests
-  schedule:
-    # Run every 9PM UTC
-    - cron:  '0 21 * * *'
-
-jobs:
-  api-validation:
-    name: Run API validation tests against a proxy for the ESS public API.
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-
-      - name: Set up Go
-        uses: actions/setup-go@v4
-        with:
-          go-version: 1.19
-        id: go
-
-      - name: Set up GitHub token auth
-        run: git config --global url."https://${GITHUB_TOKEN}:x-oauth-basic@github.com/".insteadOf "https://github.com/"
-        env:
-          GITHUB_TOKEN: ${{ secrets.GH_TOKEN_MARCLOP }}
-
-      - name: Start proxy server and run API validation tests
-        id: proxy
-        run: make validation-proxy & make wait-on-proxy && make api-validation
-        env:
-          EC_API_KEY: ${{ secrets.EC_API_KEY }}
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 23e51242..80243676 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -18,7 +18,7 @@ jobs:
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
-          token: ${{ secrets.GH_TOKEN }}
+          token: ${{ secrets.GITHUB_TOKEN }}
 
       # Create actual release
 
@@ -36,7 +36,7 @@ jobs:
         uses: ncipollo/release-action@v1
         with:
           bodyFile: notes/${{ steps.get_branch.outputs.TAGNAME }}.md
-          token: ${{ secrets.GH_TOKEN }}
+          token: ${{ secrets.GITHUB_TOKEN }}
           tag: ${{ steps.get_branch.outputs.TAGNAME }}
 
       - name: Set up Go
@@ -66,7 +66,7 @@ jobs:
         with:
           ref: master
           fetch-depth: 0
-          token: ${{ secrets.GH_TOKEN }}
+          token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Set up Go
         uses: actions/setup-go@v4
diff --git a/notes/v1.17.0.md b/notes/v1.17.0.md
new file mode 100644
index 00000000..1d12e465
--- /dev/null
+++ b/notes/v1.17.0.md
@@ -0,0 +1,18 @@
+# Changelog
+
+This release of the Elastic Cloud SDK Go should be used for ECE Version `3.7.0`.
+
+## Enhancements
+
+### Update to latest ECE 3.7.0 api ([#461](https://github.com/elastic/cloud-sdk-go/issues/461))
+
+Breaking: 
+ - The notes api is no more. Use the deployment comment api instead.
+Other: 
+ - The instance configurations can now specify allowed zones.
+ - The deployment update api can use the ValidateOnly flag
+
+### Add `show_max_zones` parameter for deployment-templates API. ([#462](https://github.com/elastic/cloud-sdk-go/issues/462))
+
+This parameter adds the `max_zones` field to each instance-configuration. (Left empty by default).
+