snaprepoapi: Add PathStyleAccess field to S3Config #426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gigerdo
approved these changes
Mar 30, 2023
|
To merge you need to sign your commits (https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) |
Add the missing `PathStyleAccess` field to the struct `S3Config` which is used for configuring S3 snapshot repositories. Also updates the outdated link to the Elasticsearch official documentation.
pascal-hofmann
force-pushed
the
feat/add-path-style-access-to-s3-config
branch
from
bef0b4d to
04a9ffc
Compare
This is fixed now. |
|
Btw. regarding the lint issues: It is indeed due to the old versions used. It still works when using an older go version (1.16 for example). We will have to update the go version and libraries to more recent ones. |
gigerdo
pushed a commit
to gigerdo/cloud-sdk-go
that referenced
this pull request
Mar 30, 2023
Add the missing `PathStyleAccess` field to the struct `S3Config` which is used for configuring S3 snapshot repositories. Also updates the outdated link to the Elasticsearch official documentation. (cherry picked from commit 0254b2d)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gigerdo
added a commit
that referenced
this pull request
Mar 30, 2023
Add the missing `PathStyleAccess` field to the struct `S3Config` which is used for configuring S3 snapshot repositories. Also updates the outdated link to the Elasticsearch official documentation. (cherry picked from commit 0254b2d) Co-authored-by: Pascal Hofmann <mail@pascalhofmann.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the missing
PathStyleAccessfield to the structS3Configwhich is used for configuring S3 snapshot repositories.See also https://www.elastic.co/guide/en/elasticsearch/reference/current/repository-s3.html#repository-s3-client
Also updates the outdated link to the Elasticsearch official documentation.
Related Issues
#425
Motivation and Context
This allows creating S3 snapshot repositories that talk to S3 backends which require path style access.
How Has This Been Tested?
Ran unit tests and tested against the ECE API.
Types of Changes
Readiness Checklist
Note: I have issues with make format and make lint. I think this happens because bin/golangci-lint is very old.