Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin removal is broken #418

Closed
dbaggott opened this issue Jan 3, 2016 · 6 comments

Comments

Projects
None yet
2 participants
@dbaggott
Copy link
Contributor

commented Jan 3, 2016

It looks like the code wasn't updated with the recent re-working of the cookbook? There's a couple of references to properties in the plugin resource that don't exist and the removal command itself is not correct (at least for ES 2.X).

The remove also doesn't do the same kind of ES version sanity checking w/r/t running as root as the install does.

@dbaggott

This comment has been minimized.

Copy link
Contributor Author

commented Jan 4, 2016

Fyi, I have a pending fix for this that I'll submit today...

dbaggott added a commit to dbaggott/cookbook-elasticsearch that referenced this issue Jan 4, 2016

Plugin removal functionality restored
* reorganizes code for DRYness
* install / remove actions both delegate to a manage_plugin method

Note: this is derived from https://github.com/elastic/cookbook-elasticsearch/tree/martinb3/chef_proxy_support and
includes its proxy support changes.  I'll clean-up this branch once that's been merged into master.

Fixes elastic#418

dbaggott added a commit to dbaggott/cookbook-elasticsearch that referenced this issue Jan 4, 2016

Plugin removal functionality restored
* reorganizes code for DRYness
* install / remove actions both delegate to a manage_plugin method

Fixes elastic#418
@martinb3

This comment has been minimized.

Copy link
Contributor

commented Jan 4, 2016

Thank you for the heads up!

dbaggott added a commit to dbaggott/cookbook-elasticsearch that referenced this issue Jan 5, 2016

Plugin removal functionality restored
* reorganizes code for DRYness
* install / remove actions both delegate to a manage_plugin method

Fixes elastic#418

dbaggott added a commit to dbaggott/cookbook-elasticsearch that referenced this issue Jan 5, 2016

Plugin removal functionality restored
* reorganizes code for DRYness
* install / remove actions both delegate to a manage_plugin method

Fixes elastic#418

@martinb3 martinb3 added the bug label Jan 8, 2016

@martinb3 martinb3 closed this in #420 Jan 8, 2016

@martinb3

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2016

Thank you @dbaggott!

@dbaggott

This comment has been minimized.

Copy link
Contributor Author

commented Jan 8, 2016

De nada. Thanks for all your work on this cookbook -- it's useful!

Any time frame for a release of recent fixes? It's not pressing but it would be nice to switch back to an official release of the cookbook.

@martinb3

This comment has been minimized.

Copy link
Contributor

commented Jan 8, 2016

@dbaggott I'll release today (Friday) -- hoping to knock out a few more of the filed issues before I hit the release buttton 👍 Thanks again for all your help!

@dbaggott

This comment has been minimized.

Copy link
Contributor Author

commented Jan 9, 2016

Sweet -- thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.