Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plugin remove #455

Merged
merged 1 commit into from Apr 28, 2016

Conversation

Projects
None yet
3 participants
@ursvasan
Copy link
Contributor

commented Apr 28, 2016

I am trying to setup my local environment to run the test (having some trouble with ruby and bundle setup), meanwhile here is what i suspect as the problem. will run the tests and update the pull request later.

This is a fix for #454

@dbaggott

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2016

+1, thanks for catching that @ursvasan

@martinb3 -- removes are broken and, as a result, you can't actually use this cookbook to upgrade an existing plugin!

@martinb3

This comment has been minimized.

Copy link
Contributor

commented Apr 28, 2016

Thank you for catching that, @ursvasan. Indeed, plugin removal was broken until a recent PR, and I apparently missed that quoting.

@martinb3 martinb3 merged commit 791a083 into elastic:master Apr 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ursvasan

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2016

@martinb3 Are you planning a release in the near future ?

@martinb3 martinb3 referenced this pull request May 3, 2016

Closed

plugin remove not working #454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.