Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix custom installation directory #80
If you set a custom installation directory using the
This pull request updates the
@karmi Sorry about the incredible delay in responding. I apparently missed your original comment on this pull request - somehow it slipped through the cracks of my email. :(
Couple thoughts. First, you wrote:
Can you explain what you mean by that? I'm not quite sure I understand.
Second, you asked if there is an easier way with Ark. I'd like to think so and I'm definitely not an expert on leveraging Ark. But... this appeared to be the only way to make it work. It's quite possible I missed something in Ark though.
Third, you're right on why the pull-request uses both
However, it seems to me that if the user defines an elasticsearch directory, that should be preferred over the global ark directory. So maybe a tidier way of expressing that would be along the lines you suggested:
@organicveggie Thanks for the update!
I agree 100% that we should honor any
@bryanwb, can you help us here a bit?
As a side note, I think we should have