From ee838e027bc4fbe77f8d1dac62b4adb5574c1bba Mon Sep 17 00:00:00 2001
From: brokensound77 <brokensound77@users.noreply.github.com>
Date: Tue, 7 Mar 2023 20:41:20 -0700
Subject: [PATCH] [Tweak] Use global constants to speed up tests

---
 tests/base.py | 23 ++++++++++++++++-------
 1 file changed, 16 insertions(+), 7 deletions(-)

diff --git a/tests/base.py b/tests/base.py
index 1dc26c674bf..263c1e5920b 100644
--- a/tests/base.py
+++ b/tests/base.py
@@ -13,6 +13,11 @@
 from detection_rules.rule_loader import DeprecatedCollection, DeprecatedRule, RuleCollection, production_filter
 
 
+RULE_LOADER_FAIL = False
+RULE_LOADER_FAIL_MSG = None
+RULE_LOADER_FAIL_RAISED = False
+
+
 @lru_cache
 def default_rules() -> RuleCollection:
     return RuleCollection.default()
@@ -27,10 +32,12 @@ class BaseRuleTest(unittest.TestCase):
 
     @classmethod
     def setUpClass(cls):
+        global RULE_LOADER_FAIL, RULE_LOADER_FAIL_MSG
+
         # too noisy; refactor
         # os.environ["DR_NOTIFY_INTEGRATION_UPDATE_AVAILABLE"] = "1"
 
-        if not cls.RULE_LOADER_FAIL:
+        if not RULE_LOADER_FAIL:
             try:
                 rc = default_rules()
                 cls.all_rules = rc.rules
@@ -38,21 +45,23 @@ def setUpClass(cls):
                 cls.production_rules = rc.filter(production_filter)
                 cls.deprecated_rules: DeprecatedCollection = rc.deprecated
             except Exception as e:
-                cls.RULE_LOADER_FAIL = True
-                cls.RULE_LOADER_FAIL_MSG = str(e)
+                RULE_LOADER_FAIL = True
+                RULE_LOADER_FAIL_MSG = str(e)
 
     @staticmethod
     def rule_str(rule: Union[DeprecatedRule, TOMLRule], trailer=' ->') -> str:
         return f'{rule.id} - {rule.name}{trailer or ""}'
 
     def setUp(self) -> None:
-        if self.RULE_LOADER_FAIL:
+        global RULE_LOADER_FAIL, RULE_LOADER_FAIL_MSG, RULE_LOADER_FAIL_RAISED
+
+        if RULE_LOADER_FAIL:
             # limit the loader failure to just one run
             # raise a dedicated test failure for the loader
-            if not self.RULE_LOADER_FAIL_RAISED:
-                self.RULE_LOADER_FAIL_RAISED = True
+            if not RULE_LOADER_FAIL_RAISED:
+                RULE_LOADER_FAIL_RAISED = True
                 with self.subTest('Test that the rule loader loaded with no validation or other failures.'):
-                    self.fail(f'Rule loader failure: \n{self.RULE_LOADER_FAIL_MSG}')
+                    self.fail(f'Rule loader failure: \n{RULE_LOADER_FAIL_MSG}')
 
             self.skipTest('Rule loader failure')
         else: