Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty technique array to rules #828

Merged

Conversation

brokensound77
Copy link
Collaborator

Issues

Resolves #812

Summary

Inserts empty array into rule payload threat mapping where technique is not defined

@brokensound77 brokensound77 added the python Internal python for the repository label Jan 11, 2021
Copy link
Contributor

@rw-access rw-access left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good

detection_rules/rule.py Outdated Show resolved Hide resolved
if include_version:
payload['version'] = self.get_version()

if embed_metadata:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, I dig this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Internal python for the repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants