From 3d43fcdd3896dcb1e3b6e8b9e6e5c55928a9ac84 Mon Sep 17 00:00:00 2001 From: Martijn Laarman Date: Tue, 8 Apr 2025 11:53:03 +0200 Subject: [PATCH] Ensure force always deletes output folder on CI regardless of generationstate --- src/Elastic.Markdown/DocumentationGenerator.cs | 3 +++ src/docs-builder/Cli/Commands.cs | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Elastic.Markdown/DocumentationGenerator.cs b/src/Elastic.Markdown/DocumentationGenerator.cs index 020fefd65..bb61348d0 100644 --- a/src/Elastic.Markdown/DocumentationGenerator.cs +++ b/src/Elastic.Markdown/DocumentationGenerator.cs @@ -90,6 +90,9 @@ public async Task GenerateAll(Cancel ctx) var generationState = GetPreviousGenerationState(); if (!Context.SkipMetadata && (Context.Force || generationState == null)) DocumentationSet.ClearOutputDirectory(); + // always delete output folder on CI + else if (!string.IsNullOrEmpty(Environment.GetEnvironmentVariable("GITHUB_ACTIONS"))) + DocumentationSet.ClearOutputDirectory(); if (CompilationNotNeeded(generationState, out var offendingFiles, out var outputSeenChanges)) return; diff --git a/src/docs-builder/Cli/Commands.cs b/src/docs-builder/Cli/Commands.cs index 55aeadfc2..dfb3515cb 100644 --- a/src/docs-builder/Cli/Commands.cs +++ b/src/docs-builder/Cli/Commands.cs @@ -105,7 +105,10 @@ public async Task Generate( Uri? canonicalBaseUri; if (runningOnCi) - force ??= true; + { + ConsoleApp.Log($"Build running on CI, forcing a full rebuild of the destination folder"); + force = true; + } if (canonicalBaseUrl is null) canonicalBaseUri = new Uri("https://docs-v3-preview.elastic.dev");