Skip to content

Fix content-source match when it has no matches #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2025
Merged

Fix content-source match when it has no matches #2096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/tooling/docs-assembler/Cli/ContentSourceCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,13 @@ public async Task<int> Match([Argument] string? repository = null, [Argument] st
var fs = new FileSystem();
var service = new RepositoryBuildMatchingService(logFactory, configuration, configurationContext, githubActionsService, fs);
serviceInvoker.AddCommand(service, (repository, branchOrTag),
static async (s, collector, state, _) => await s.ShouldBuild(collector, state.repository, state.branchOrTag)
);
static async (s, collector, state, ctx) =>
{
_ = await s.ShouldBuild(collector, state.repository, state.branchOrTag);
// ShouldBuild throws an exception on bad args and will return false if it has no matches
// We return true to the service invoker to continue
return true;
});

return await serviceInvoker.InvokeAsync(ctx);
}
Expand Down
9 changes: 7 additions & 2 deletions src/tooling/docs-builder/Commands/Assembler/ContentSourceCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,13 @@ public async Task<int> Match([Argument] string? repository = null, [Argument] st
var fs = new FileSystem();
var service = new RepositoryBuildMatchingService(logFactory, configuration, configurationContext, githubActionsService, fs);
serviceInvoker.AddCommand(service, (repository, branchOrTag),
static async (s, collector, state, _) => await s.ShouldBuild(collector, state.repository, state.branchOrTag)
);
static async (s, collector, state, ctx) =>
{
_ = await s.ShouldBuild(collector, state.repository, state.branchOrTag);
// ShouldBuild throws an exception on bad args and will return false if it has no matches
// We return true to the service invoker to continue
return true;
});

return await serviceInvoker.InvokeAsync(ctx);
}
Expand Down
Loading