From df007c565e7a5fc2181e6eed4f8ace72f3fba193 Mon Sep 17 00:00:00 2001 From: Jan Calanog Date: Wed, 12 Nov 2025 12:32:16 +0100 Subject: [PATCH] Fix span naming conventions --- src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs | 2 +- .../Adapters/AskAi/StreamTransformerBase.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs b/src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs index ef4db52d3..92ef71ef5 100644 --- a/src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs +++ b/src/api/Elastic.Documentation.Api.Core/AskAi/AskAiUsecase.cs @@ -18,7 +18,7 @@ public class AskAiUsecase( public async Task AskAi(AskAiRequest askAiRequest, Cancel ctx) { logger.LogInformation("Starting AskAI chat with {AgentProvider} and {AgentId}", streamTransformer.AgentProvider, streamTransformer.AgentId); - var activity = AskAiActivitySource.StartActivity($"chat", ActivityKind.Client); + var activity = AskAiActivitySource.StartActivity($"chat ${streamTransformer.AgentProvider}", ActivityKind.Client); _ = activity?.SetTag("gen_ai.operation.name", "chat"); _ = activity?.SetTag("gen_ai.provider.name", streamTransformer.AgentProvider); // agent-builder or llm-gateway _ = activity?.SetTag("gen_ai.agent.id", streamTransformer.AgentId); // docs-agent or docs_assistant diff --git a/src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/StreamTransformerBase.cs b/src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/StreamTransformerBase.cs index 7e75836f6..f949249d2 100644 --- a/src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/StreamTransformerBase.cs +++ b/src/api/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/StreamTransformerBase.cs @@ -124,7 +124,7 @@ private async Task ProcessPipeAsync(PipeReader reader, PipeWriter writer, string /// Stream processing result with metrics and captured output protected virtual async Task ProcessStreamAsync(PipeReader reader, PipeWriter writer, string? conversationId, Activity? parentActivity, CancellationToken cancellationToken) { - using var activity = StreamTransformerActivitySource.StartActivity(nameof(ProcessStreamAsync)); + using var activity = StreamTransformerActivitySource.StartActivity("process ask_ai stream", ActivityKind.Internal); if (parentActivity?.Id != null) _ = activity?.SetParentId(parentActivity.Id); @@ -157,7 +157,7 @@ protected virtual async Task ProcessStreamAsync(PipeReader reader, PipeWriter wr continue; } - using var parseActivity = StreamTransformerActivitySource.StartActivity("AskAI Event"); + using var parseActivity = StreamTransformerActivitySource.StartActivity("parse ask_ai event"); // Set event type tag on parse_event activity _ = parseActivity?.SetTag("ask_ai.event.type", transformedEvent.GetType().Name);