-
Notifications
You must be signed in to change notification settings - Fork 32
Add distributed caching for GCP ID tokens #2278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/MultiLayerCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/MultiLayerCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/MultiLayerCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/MultiLayerCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
src/api/Elastic.Documentation.Api.Infrastructure/Caching/DynamoDbDistributedCache.cs
Fixed
Show fixed
Hide fixed
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
tests/Elastic.Documentation.Api.Infrastructure.Tests/Caching/DistributedCacheTests.cs
Fixed
Show fixed
Hide fixed
Mpdreamz
approved these changes
Nov 27, 2025
tests/Elastic.Documentation.Api.Infrastructure.Tests/Caching/DistributedCacheTests.cs
Fixed
Show fixed
Hide fixed
… IDisposable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lambda containers were each generating GCP ID tokens independently.
When many containers start at once, they all call Google OAuth at the same time,
causing rate limit errors.
Solution
Implemented two-tier distributed cache to share tokens across all Lambda containers:
others reuse it (prevents all containers calling Google at once)
Changes
Infrastructure Required
DynamoDB table: docs-api-cache-${environment} with CacheKey partition key and TTL enabled.
Lambda IAM: dynamodb:GetItem + dynamodb:PutItem permissions.