From 9cbf9e6586cba409c1095a930126ee5cb622acac Mon Sep 17 00:00:00 2001 From: Jan Calanog Date: Wed, 19 Feb 2025 22:40:56 +0100 Subject: [PATCH 1/4] Always deploy --- .github/workflows/preview-build.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/preview-build.yml b/.github/workflows/preview-build.yml index 3171db286..1f3731a8b 100644 --- a/.github/workflows/preview-build.yml +++ b/.github/workflows/preview-build.yml @@ -130,11 +130,11 @@ jobs: strict: ${{ fromJSON(inputs.strict != '' && inputs.strict || 'true') }} - uses: elastic/docs-builder/.github/actions/aws-auth@main - if: steps.deployment.outputs.result + if: ${{ !cancelled() }} - name: Upload to S3 id: s3-upload - if: steps.deployment.outputs.result + if: ${{ !cancelled() }} run: | aws s3 sync .artifacts/docs/html "s3://elastic-docs-v3-website-preview${PATH_PREFIX}" --delete aws cloudfront create-invalidation \ @@ -156,7 +156,7 @@ jobs: owner: context.repo.owner, repo: context.repo.repo, deployment_id: ${{ steps.deployment.outputs.result }}, - state: "${{ job.status == 'success' && 'success' || 'failure' }}", + state: "${{ steps.s3-upload.outcome == 'success' && 'success' || 'failure' }}", environment_url: `https://docs-v3-preview.elastic.dev${process.env.PATH_PREFIX}`, log_url: `https://github.com/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`, }) From 90165cd79180d8ed6ecdd049014ecaae4b56e3e2 Mon Sep 17 00:00:00 2001 From: Jan Calanog Date: Wed, 19 Feb 2025 22:44:19 +0100 Subject: [PATCH 2/4] test --- docs/index.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/index.md b/docs/index.md index 9939a9b4b..a40333f8e 100644 --- a/docs/index.md +++ b/docs/index.md @@ -9,3 +9,6 @@ Elastic Docs V3 is our next-generation documentation platform designed to improv * [Configure content sets in V3](./configure/index.md) * [Learn about V3 syntax](./syntax/index.md) * [Contribute to V3 (developer guide)](./development/index.md) + + +[empty url]() From 62557c8904cc01658f9ce75b85d655d87987c128 Mon Sep 17 00:00:00 2001 From: Jan Calanog Date: Wed, 19 Feb 2025 22:45:38 +0100 Subject: [PATCH 3/4] Revert "test" This reverts commit 90165cd79180d8ed6ecdd049014ecaae4b56e3e2. --- docs/index.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/docs/index.md b/docs/index.md index a40333f8e..9939a9b4b 100644 --- a/docs/index.md +++ b/docs/index.md @@ -9,6 +9,3 @@ Elastic Docs V3 is our next-generation documentation platform designed to improv * [Configure content sets in V3](./configure/index.md) * [Learn about V3 syntax](./syntax/index.md) * [Contribute to V3 (developer guide)](./development/index.md) - - -[empty url]() From 1fef0aabbdaabd9a36ad3bf81943cad964327a58 Mon Sep 17 00:00:00 2001 From: Jan Calanog Date: Wed, 19 Feb 2025 22:59:34 +0100 Subject: [PATCH 4/4] Fix conditions --- .github/workflows/preview-build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/preview-build.yml b/.github/workflows/preview-build.yml index 1f3731a8b..ff8f42e74 100644 --- a/.github/workflows/preview-build.yml +++ b/.github/workflows/preview-build.yml @@ -130,11 +130,11 @@ jobs: strict: ${{ fromJSON(inputs.strict != '' && inputs.strict || 'true') }} - uses: elastic/docs-builder/.github/actions/aws-auth@main - if: ${{ !cancelled() }} + if: ${{ !cancelled() && steps.deployment.outputs.result }} - name: Upload to S3 id: s3-upload - if: ${{ !cancelled() }} + if: ${{ !cancelled() && steps.deployment.outputs.result }} run: | aws s3 sync .artifacts/docs/html "s3://elastic-docs-v3-website-preview${PATH_PREFIX}" --delete aws cloudfront create-invalidation \