From be05189cf13f804264d92d935c8227f1b51f90a0 Mon Sep 17 00:00:00 2001 From: Martijn Laarman Date: Fri, 4 Apr 2025 11:09:22 +0200 Subject: [PATCH] Fix misplaced guard for checking for updates on CI --- src/docs-builder/Cli/CheckForUpdatesFilter.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/docs-builder/Cli/CheckForUpdatesFilter.cs b/src/docs-builder/Cli/CheckForUpdatesFilter.cs index 11330ffc2..4d9778c60 100644 --- a/src/docs-builder/Cli/CheckForUpdatesFilter.cs +++ b/src/docs-builder/Cli/CheckForUpdatesFilter.cs @@ -16,6 +16,9 @@ internal sealed class CheckForUpdatesFilter(ConsoleAppFilter next) : ConsoleAppF public override async Task InvokeAsync(ConsoleAppContext context, Cancel ctx) { await Next.InvokeAsync(context, ctx); + if (!string.IsNullOrEmpty(Environment.GetEnvironmentVariable("CI"))) + return; + var latestVersionUrl = await GetLatestVersion(ctx); if (latestVersionUrl is null) ConsoleApp.LogError("Unable to determine latest version"); @@ -54,9 +57,6 @@ private static void CompareWithAssemblyVersion(Uri latestVersionUrl) private async ValueTask GetLatestVersion(Cancel ctx) { - if (!string.IsNullOrEmpty(Environment.GetEnvironmentVariable("CI"))) - return null; - // only check for new versions once per hour if (_stateFile.Exists && _stateFile.LastWriteTimeUtc >= DateTime.UtcNow.Subtract(TimeSpan.FromHours(1))) {