-
Notifications
You must be signed in to change notification settings - Fork 182
Small fix in ECK Helm config docs #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
|
This is interesting @kilfoyle ! This is actually a bug caused by me, let me explain. I thought the helm chart passes directly everything inside
That's documented here. The problem is that the helm chart is using its own configuration parameters instead of directly relying on the actual ECK parameters (this shows how To solve this we need to change a bit the narrative, because I wanted to tell users (on purpose) that they can configure ANY ECK setting documented in the ECK reference doc using the helm chart under the And that's definitely incorrect now that I see the chart, sorry! Let me share some small suggestions to address this change in a different way. For example, what you have added as a TIP should moved more to the beginning of the section, and probably we should add a note saying that the Helm chart does NOT use the standard configuration parameters documented in (LINK TO REFERENCE), and suggest to use the cc: @elastic/cloud-k8s , just in case you want to add anything here. |
eedugon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving, but to avoid future misunderstandings I think we have to update a bit the introduction of that section, as my current original intro would cause confusion if we don't explain that the helm chart uses its own settings for the ECK configuration flags (they are not just passed through).
|
Thanks a lot @eedugon for explaining! I've updated the section so that we can explain at the top of the Helm section about the Helm settings being different from the ECK settings. I assume that Option 2, using the
|
|
beautiful!!!!! Many thanks for this! |
|
|
||
| ```sh | ||
| helm upgrade elastic-operator elastic/eck-operator --set config.ca-cert-validity=43800h -n elastic-system | ||
| helm upgrade elastic-operator elastic/eck-operator --set config.caValidity=43800h -n elastic-system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch :)


According to issue #2089, the Helm
ca-cert-validitysetting documented on the Apply ECK configuration settings page should rather becaValidity. This also adds a tip for generating the list of valid settings.I'm not familiar with these settings at all so I'd appreciate if anyone can confirm that this change is correct.