Clarify terraform serverless support #3934
Conversation
Terraform is supposed to be supported on serverless
kunisen
added
documentation
🔍 Preview links for changed docs |
yetanothertw
left a comment
yetanothertw
left a comment
There was a problem hiding this comment.
@kunisen thank you so much for working on this! 🙏
I've approved the PR, but have recommended some updates and provided a bit more context around tagging (I know that can be very confusing).
| deployment: | ||
| ess: ga | ||
| serverless: unavailable | ||
| serverless: ga |
There was a problem hiding this comment.
In this situation (where we want to signal that you can provision Serverless projects on a section level), I would recommend removing the applies_to tag altogether. Here's why:
- The page-level metadata already includes the
serverless: gatag, which signals that all sections on this page are applicable in a Serverless context unless stated otherwise (for example the ECCTL section). - The page-level metadata also includes the ECH tag, which implies that all section are applicable in that context unless specified otherwise. So we'd only need to mark something as unavailble (the outlier sections on the page). Because our changes want to signal availability, we would default to the page-level tags.
I know the tagging can be a bit confusing, so hope that helps, but please feel free to reach out for more information or whenever you're unsure. 💟
There was a problem hiding this comment.
It makes total sense. Thank you @yetanothertw for the very detailed explanation!
I will make sure to keep this in my mind for the future doc related work too. 🙏
I will make a commit to remove the tag.
There was a problem hiding this comment.
I can confirm the tags are removed as expected ^ ^
There was a problem hiding this comment.
I will merge the PR since we have addressed all the action items. Thank you @yetanothertw again for the valuable inputs! 🙇
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
|
Thanks so much for getting this moved so quickly @kunisen ! 🎉 |
Description
Terraform is supposed to be supported on serverless
To address below issues:
Preview - before merge
deploy-manage/deploy/elastic-cloud/tools-apis.md
Preview - after merge
https://www.elastic.co/docs/deploy-manage/deploy/elastic-cloud/tools-apis#provision-deployments-with-terraform
cc @maggieghamry @ppf2