-
Notifications
You must be signed in to change notification settings - Fork 185
[ResponseOps][9.3 & Serverless]: Scheduled reports new email fields and Mustache support #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nastasha-solomon
wants to merge
7
commits into
main
Choose a base branch
from
issue-4027-schedule-reports
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
48c44dc
First draft
nastasha-solomon 2199130
Modified descriptions
nastasha-solomon 83c7fd9
Merge branch 'main' into issue-4027-schedule-reports
nastasha-solomon 3a47e88
Update explore-analyze/report-and-share/automating-report-generation.md
nastasha-solomon a7a0da8
Update explore-analyze/report-and-share/automating-report-generation.md
nastasha-solomon aa69176
Merge branch 'main' into issue-4027-schedule-reports
nastasha-solomon 5f66d7f
Merge branch 'main' into issue-4027-schedule-reports
nastasha-solomon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umbopepato we may need to define the list of variables that users can select for the email subject and message, especially if they're not clearly defined in the UI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also apply? https://www.elastic.co/docs/explore-analyze/alerts-cases/alerts/rule-action-variables#enhance-mustache-variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooo good question. @umbopepato can you help with this question? ^
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Variables are listed, with descriptions, in the picker just above the subject and message fields. In case we want to list the available vars in the docs as well, here's the data model we use to render the picker.
Good point @bmorelli25! Yes, we're using the same Mustache rendering functions as in actions, so the same lambdas are available.
@nastasha-solomon shall we specify that the message field also supports Markdown? It has implications on how Mustache is compiled, since a dedicated escape strategy is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Can you share the method of escaping markdown in mustache templates?