Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stack: Skip returning an error on packed __MACOSX #105

Merged
merged 2 commits into from
Dec 20, 2019
Merged

stack: Skip returning an error on packed __MACOSX #105

merged 2 commits into from
Dec 20, 2019

Conversation

marclop
Copy link
Collaborator

@marclop marclop commented Dec 19, 2019 •
edited
Loading

Description

Skips returning an error on stackpacks which have a __MACOSX packed into
the .zip file.

Motivation and Context

ECE stack packs seem to have a __MACOSX packed file which is causing the command to return an error.

$ecctl platform stack upload 7.5.1.zip
1 error occurred:
	* stackpack.invalid_configuration_version: This version cannot be parsed: [__MACOSX] because: Unknown version string: [__MACOSX]

How Has This Been Tested?

Maually

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)

@marclop
stack: Skip returning an error on packed __MACOSX
040a0fb 
Skips returning an error on stackpacks which have a __MACOSX packed into
the .zip file.

Signed-off-by: Marc Lopez <marc5.12@outlook.com>
@marclop marclop added bug Something isn't working loe:small labels Dec 19, 2019
@marclop marclop added this to the 33: Dec 04 - Dec 24 milestone Dec 19, 2019
@marclop marclop requested a review from a team as a code owner December 19, 2019 07:16
@marclop marclop self-assigned this Dec 19, 2019
@karencfv karencfv mentioned this pull request Dec 19, 2019
Closed
@infraredgirl
Copy link
Contributor

What a weird bug 😄

The code LGTM, I would maybe just add a comment explaining the purpose of the if statement, otherwise I think it would be hard for someone reading the code to understand why it's there. The same text that you have under "Motivation and context" I think would suffice.

@marclop
Add comment on the __MACOSX error message
051a6c2 
Signed-off-by: Marc Lopez <marc5.12@outlook.com>
@marclop marclop merged commit 5939798 into elastic:master Dec 20, 2019
@marclop marclop deleted the b/fix-error-message-___MACOSX-on-stack-upload branch December 20, 2019 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppapapetrou76 ppapapetrou76 ppapapetrou76 approved these changes

Assignees

@marclop marclop

Labels
bug Something isn't working
Projects
None yet
Milestone
33: Dec 04 - Dec 24
Development

Successfully merging this pull request may close these issues.
3 participants
@marclop @infraredgirl @ppapapetrou76