Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: improve UX by defining which commands are admin specific #174

Merged
merged 4 commits into from Feb 12, 2020

Conversation

karencfv
Copy link
Contributor

Description

This PR introduces the text "(Requires platform administration privileges)" to those commands that require it. This improves UX for ESS users.

Related Issues

Related: #160

Motivation and Context

After a conversation in #169 it was concluded that the best way forward was to use the text mentioned previously.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@karencfv karencfv added documentation Improvements or additions to documentation loe:small labels Feb 11, 2020
@karencfv karencfv added this to the 36: Feb 05 - Feb 25 milestone Feb 11, 2020
@karencfv karencfv requested a review from a team as a code owner February 11, 2020 00:34
@karencfv karencfv self-assigned this Feb 11, 2020
@karencfv
Copy link
Contributor Author

Moving the conversation over to this PR. If any changes need to be addressed let's do it here :)

Copy link
Contributor

@ppapapetrou76 ppapapetrou76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @karencfv 🙆

@karencfv karencfv merged commit b2c7f1a into elastic:master Feb 12, 2020
@karencfv karencfv deleted the cmd-help-text-modification branch February 12, 2020 21:07
@Kushmaro
Copy link
Contributor

Kushmaro commented Feb 13, 2020

Hey @karencfv
I've discussed this one with @uric

really sorry for the hassle, but could we please change the “Requires platform administration privileges” to “Available for ECE only”

We believe this would make more sense from an ESS user's perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants