Skip to content

Conversation

@bmorelli25
Copy link
Member

Summary

This PR adds ecs-logging-ruby docs. Shared content is included from the ecs-logging repo.

To test this PR, you'll need an up-to-date copy of both elastic/docs and elastic/ecs-logging. Then run the following command, where $GIT_HOME is the path to your local repos:

$GIT_HOME/docs/build_docs --doc $GIT_HOME/ecs-logging-ruby/docs/index.asciidoc --resource=$GIT_HOME/ecs-logging/docs/ --chunk 1 --open

Follow-ups

  • Open PR in elastic/docs to add to the build
  • Open infra ticket to add the docs check to this repo
  • Add webhook for docs check
  • Remove content from readme and link to docs

@bmorelli25 bmorelli25 added the documentation Improvements or additions to documentation label Dec 14, 2020
@bmorelli25 bmorelli25 requested a review from a team December 14, 2020 22:41
@bmorelli25 bmorelli25 self-assigned this Dec 14, 2020
@ghost
Copy link

ghost commented Dec 14, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #7 opened

  • Start Time: 2020-12-14T22:41:23.320+0000

  • Duration: 14 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 224
Skipped 0
Total 224

Copy link
Contributor

@mikker mikker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, Brandon! Thank you 🙏

@bmorelli25 bmorelli25 mentioned this pull request Dec 15, 2020
5 tasks
@bmorelli25
Copy link
Member Author

No prob! Opened #8 to track the follow-ups.

@bmorelli25 bmorelli25 merged commit 58802ab into elastic:master Dec 15, 2020
@bmorelli25 bmorelli25 deleted the init-docs branch December 15, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-ruby documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants