Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flag #56

Merged
merged 40 commits into from
Mar 9, 2023
Merged

Add feature flag #56

merged 40 commits into from
Mar 9, 2023

Commits on Mar 7, 2023

  1. update go version

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    dc56eca View commit details
    Browse the repository at this point in the history

  2. add feature flag to control protocol

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    228782c View commit details
    Browse the repository at this point in the history

  3. wip

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9faa3f2 View commit details
    Browse the repository at this point in the history

  4. wip

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    460fc3f View commit details
    Browse the repository at this point in the history

  5. .

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    ce64944 View commit details
    Browse the repository at this point in the history

  6. Feature flags and Units are a "change" 

    Generalize the unit changed to a general change that can come from a unit or feature flag
    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4492e98 View commit details
    Browse the repository at this point in the history

  7. using a Trigger to indicate what changed

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    698cf1d View commit details
    Browse the repository at this point in the history

  8. update generated code

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    40b1fda View commit details
    Browse the repository at this point in the history

  9. fix tests

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9a53e5a View commit details
    Browse the repository at this point in the history

  10. don't use prot.Features, send on 1st checkin, adjust tests

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    e5d4cbc View commit details
    Browse the repository at this point in the history

  11. .

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    b062645 View commit details
    Browse the repository at this point in the history

  12. always send features

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    5635875 View commit details
    Browse the repository at this point in the history

  13. use feature change to determine if unit changed

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    7c7d74c View commit details
    Browse the repository at this point in the history

  14. always send feature changed trigger

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    496759f View commit details
    Browse the repository at this point in the history

  15. add featuresIdx, triggers is a bitmask

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    0a0b3d0 View commit details
    Browse the repository at this point in the history

  16. WIP: changes as I tested the agent with the fake inut

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    40b9cd2 View commit details
    Browse the repository at this point in the history

  17. mage check

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    24b65f0 View commit details
    Browse the repository at this point in the history

  18. remove client.syncFeatures

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4c970c2 View commit details
    Browse the repository at this point in the history

  19. send features on unit removed and change Trigger.String

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    44c52ae View commit details
    Browse the repository at this point in the history

  20. Adjust Trigger String method

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    c23dd09 View commit details
    Browse the repository at this point in the history

  21. fix tests

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    e416270 View commit details
    Browse the repository at this point in the history

  22. add feature flags to UnitChange

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    e31ef9e View commit details
    Browse the repository at this point in the history

  23. .

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    320d333 View commit details
    Browse the repository at this point in the history

  24. add and fix tests, some PR and small changes

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    201094e View commit details
    Browse the repository at this point in the history

  25. remove stringer usage

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    feba3f0 View commit details
    Browse the repository at this point in the history

  26. rebase and go mod tidy

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    40bdac0 View commit details
    Browse the repository at this point in the history

  27. fix test

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    39ca174 View commit details
    Browse the repository at this point in the history

  28. tests fixed

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    35b9f3b View commit details
    Browse the repository at this point in the history

  29. add GoString and don't send nil FeatureFlags

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    d8975ea View commit details
    Browse the repository at this point in the history

  30. .

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    56d8b4a View commit details
    Browse the repository at this point in the history

  31. making linter happy

    @AndersonQ @ycombinator
    AndersonQ authored and ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    acba3c0 View commit details
    Browse the repository at this point in the history

  32. Remove stringer setup from magefile

    @ycombinator
    ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    1bb9fcf View commit details
    Browse the repository at this point in the history

  33. Fixing rebase errors

    @ycombinator
    ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    b9b4996 View commit details
    Browse the repository at this point in the history

  34. Fixing duplicate mention in comment

    @ycombinator
    ycombinator committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    09474ef View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Pass unit features to unit constructor

    @ycombinator
    ycombinator committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ee7eef8 View commit details
    Browse the repository at this point in the history

  2. Remove features information from client

    @ycombinator
    ycombinator committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    29534aa View commit details
    Browse the repository at this point in the history

  3. Remove features from UnitChanged as they are already part of Unit ins… 

    …ide UnitChanged
    @ycombinator
    ycombinator committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    02662bf View commit details
    Browse the repository at this point in the history

  4. Fixing up tests

    @ycombinator
    ycombinator committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    d7d45d9 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Start UnitChangedType constants' numbering at 1

    @ycombinator
    ycombinator committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    b70d208 View commit details
    Browse the repository at this point in the history

  2. Add comments about Trigger values being bitmasks

    @ycombinator
    ycombinator committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    5cfba1d View commit details
    Browse the repository at this point in the history