Skip to content

Conversation

@belimawr
Copy link
Contributor

What does this PR do?

This commit fixes mage fmt and reformat the code.

Why is it important?

It reformats the code, so if people run mage fmt on their PRs there are no changes unrelated to their code.

## Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • ~I have added tests that prove my fix is effective or that my feature works~~

## Author's Checklist
## Related issues

This commit fixes `mage fmt` and reformat the code.
@belimawr belimawr self-assigned this Oct 24, 2025
@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 24, 2025
@belimawr belimawr requested a review from a team as a code owner October 24, 2025 20:48
@belimawr belimawr requested review from mauri870 and rdner and removed request for a team October 24, 2025 20:48
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @belimawr

Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It seems we don't run mage fmt in CI to compare against the PR code, so I'm wondering if things might eventually degrade again as new code is pushed, since nothing is enforcing it.

@belimawr
Copy link
Contributor Author

Thanks. It seems we don't run mage fmt in CI to compare against the PR code, so I'm wondering if things might eventually degrade again as new code is pushed, since nothing is enforcing it.

Yeah, they will. We need to add a check step like we do in Beats. I'll create an PR for that, it's such a small and impact-full change.

@belimawr belimawr merged commit 1a87127 into elastic:main Oct 27, 2025
2 of 5 checks passed
@belimawr belimawr mentioned this pull request Oct 27, 2025
3 tasks
@belimawr
Copy link
Contributor Author

Thanks. It seems we don't run mage fmt in CI to compare against the PR code, so I'm wondering if things might eventually degrade again as new code is pushed, since nothing is enforcing it.

Yeah, they will. We need to add a check step like we do in Beats. I'll create an PR for that, it's such a small and impact-full change.

The root cause was fmt missing from the check target, #364 will fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants