-
Notifications
You must be signed in to change notification settings - Fork 204
Allow overriding otel exporter and extension configuration for outputs #10992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request does not have a backport label. Could you fix it @swiatekm? 🙏
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
leehinman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank You. I really like how straight forward this is.
|
You can Unskip the test below now after enabling elastic-agent/testing/integration/ess/beat_receivers_test.go Lines 1117 to 1133 in a24b6fa
|
ddaf99f to
42658df
Compare
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @swiatekm |
cmacknz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works as expected. Thanks!
elastic#10992) * Allow overriding otel exporter config * Allow overriding otel output extension config * Unskip integration test with override
What does this PR do?
Allows otel component configurations generated from output configuration to be overridden. In the output configuration, we have a new optional
otelsection:otel.extensions.<extension_name>contains configuration for the generated extension, whileotel.exporter, for the exporter.These configurations are merged into the generated configuration and take precedence over it. There aren't any validity checks here, so the feature should be used with care. It's only intended as a stopgap measure to mitigate unforeseen problems.
Why is it important?
If it turns out there's an issue with the configuration translation, we want to have an escape hatch to mitigate it for affected customers.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
Build the agent package, then run it with the following configuration:
Then collect diagnostics and look at the final otel configuration. It should contain the output overrides.
Related issues