Set max_shards_per_node to 2000 for the integration test cluster #11348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our integration tests create a lot of indices due to each test running in its own namespace. Increase the limit, as the performance penalty doesn't matter for the purpose of our tests.
swiatekm
added
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
swiatekm
changed the title
blakerouse
approved these changes
Nov 21, 2025
Contributor
|
@Mergifyio backport 8.19 9.1 9.2 |
Contributor
✅ Backports have been created
|
Contributor
💛 Build succeeded, but was flaky
Failed CI Stepscc @swiatekm |
mergify bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
Our integration tests create a lot of indices due to each test running in its own namespace. Increase the limit, as the performance penalty doesn't matter for the purpose of our tests. (cherry picked from commit 81150c8)
mergify bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
Our integration tests create a lot of indices due to each test running in its own namespace. Increase the limit, as the performance penalty doesn't matter for the purpose of our tests. (cherry picked from commit 81150c8)
This was referenced Nov 21, 2025
Merged
mergify bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
Our integration tests create a lot of indices due to each test running in its own namespace. Increase the limit, as the performance penalty doesn't matter for the purpose of our tests. (cherry picked from commit 81150c8)
swiatekm
added a commit
that referenced
this pull request
Nov 21, 2025
Our integration tests create a lot of indices due to each test running in its own namespace. Increase the limit, as the performance penalty doesn't matter for the purpose of our tests. (cherry picked from commit 81150c8) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm
added a commit
that referenced
this pull request
Nov 21, 2025
Our integration tests create a lot of indices due to each test running in its own namespace. Increase the limit, as the performance penalty doesn't matter for the purpose of our tests. (cherry picked from commit 81150c8) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm
added a commit
that referenced
this pull request
Nov 21, 2025
Our integration tests create a lot of indices due to each test running in its own namespace. Increase the limit, as the performance penalty doesn't matter for the purpose of our tests. (cherry picked from commit 81150c8) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
hayotbisonai
pushed a commit
to hayotbisonai/elastic-agent
that referenced
this pull request
Nov 23, 2025
Our integration tests create a lot of indices due to each test running in its own namespace. Increase the limit, as the performance penalty doesn't matter for the purpose of our tests.
swiatekm
added a commit
that referenced
this pull request
Nov 24, 2025
Our integration tests create a lot of indices due to each test running in its own namespace. Increase the limit, as the performance penalty doesn't matter for the purpose of our tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our integration tests create a lot of indices due to each test running in its own namespace. Recently, we've been hitting the per-node cluster wide limit of 1000 shards, causing some tests to randomly be flaky - see #11325 for example.
I've looked into this in #11329, and it does look like we create almost 500 indicies, each of which gets an inactive replica shard that counts towards the limit. I tried to disable replication at first, but doing so for managed indices turns out to be a huge pain. Instead, I decided to just increase the limit, as the replica shards aren't really doing much anyway.