Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Merge v2 feature branch into main #1701

Merged
merged 37 commits into from Nov 9, 2022
Merged

[v2] Merge v2 feature branch into main #1701

merged 37 commits into from Nov 9, 2022

Conversation

blakerouse
Copy link
Contributor

What does this PR do?

Merges new v2 architecture work into main for 8.6.

Why is it important?

To get v2 into 8.6.

blakerouse and others added 30 commits June 3, 2022 09:24
* Add v2 component specification and validation.

* Remove i386 and ppc64el. Update spec for osquerybeat.

* Remove windows/arm64.
* Upgrade elastic-agent-client.

* Calculate the expected running components and units from the v2 specification and the current policy.

* Update NOTICE.txt.

* Fix lint from servicable main.go.

* Update GRPC for the agent CLI control protocol. Fix name collision issue.

* Run go mod tidy.

* Fix more lint issues.

* Fix fmt.

* Update logic to always compute model, with err set on each component. Check runtime preventions at model generation time.

* Fix items from code review, and issue on windows test runner.

* Try to cleanup duplication in tests.

* Try 2 of fixing duplicate lint failure, that is not really a duplicate.

* Re-run mage fmt.

* Lint fixes for linux, why different?

* Fix nolint comment.

* Add comment.
Flattening the structure and removing download/install steps for programs. 

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
* generating checksum?

* yaml output

* Update dev-tools/mage/common.go

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>

* review

* ioutil removal from magefile

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
* Add runtime for command v2 components.

* Fix imports.

* Add tests for watching checkins.

* Fix lint and move checkin period to a configurable timeout.

* Fix tests now that checkin timeout needs to be defined.

* Fix code review and lint.
…753)

* Add runtime for command v2 components.

* Fix imports.

* Add tests for watching checkins.

* Fix lint and move checkin period to a configurable timeout.

* Fix tests now that checkin timeout needs to be defined.

* Fix code review and lint.

* Work on actually running the v2 runtime.

* Work on switching to the v2 runtime.

* More work on switching to v2 runtime.

* Cleanup some imports.

* More import cleanups.

* Add TODO to FleetServerComponentModifier.

* Remove outdated managed_mode_test.go.

* Fixes from code review and lint.
* Add runtime for command v2 components.

* Fix imports.

* Add tests for watching checkins.

* Fix lint and move checkin period to a configurable timeout.

* Fix tests now that checkin timeout needs to be defined.

* Fix code review and lint.

* Work on actually running the v2 runtime.

* Work on switching to the v2 runtime.

* More work on switching to v2 runtime.

* Cleanup some imports.

* More import cleanups.

* Add TODO to FleetServerComponentModifier.

* More cleanup and removals.

* Remove more.

* Delete more unused code.

* Clean up step_download from refactor.

* Remove outdated managed_mode_test.go.

* Fixes from code review and lint.

* Fix lint and missing errcheck.
* Remove more unused code that was including already deleted code.

* Fix all unit tests.

* Fix lint.

* More lint fixes, maybe this time?

* More lint.... really?

* Update NOTICE.txt.
* [Automation] Update elastic stack version to 8.4.0-40cff009 for testing (#557)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-5e6770b1 for testing (#564)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix regression and use comma separated values (#560)

Fix regression from #509

* Change in Jenkinsfile will trigger k8s run (#568)

* [Automation] Update elastic stack version to 8.4.0-da5a1c6d for testing (#573)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add `@metadata.input_id` and `@metadata.stream_id` when injecting streams (#527)

These 2 value are going to be used in the shipper to identify where an
event came from in order to apply processors accordingly.

Also, added test cases for the processor to verify the change and updated test cases with the new processor.

* Add filemod times to contents of diagnostics collect command (#570)

* Add filemod times to contents of diagnostics collect command

Add filemod times to the files and directories in the zip archive.
Log files (and sub dirs) will use the modtime returned by the fileinfo
for the source. Others will use the timestamp from when the zip is
created.

* Fix linter

* [Automation] Update elastic stack version to 8.4.0-b13123ee for testing (#581)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix Agent upgrade 8.2->8.3 (#578)

* Fix Agent upgrade 8.2->8.3
* Improve the upgrade encryption handling. Add .yml files cleanup.
* Rollback ActionUpgrade to action_id, add MarkerActionUpgrade adapter struct for marker serialization compatibility

* Update containerd (#577)

* [Automation] Update elastic stack version to 8.4.0-4fe26f2a for testing (#591)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Set explicit ExitTimeOut for MacOS agent launchd plist (#594)

* Set explicit ExitTimeOut for MacOS agent launchd plist

* [Automation] Update elastic stack version to 8.4.0-2e32a640 for testing (#599)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: enable build notifications as GitHub issues (#595)

* status identifies failing component, fleet gateway may report degraded, liveness endpoint added (#569)

* Add liveness endpoint

Add /liveness route to metrics server. This route will report the status
from pkg/core/status. fleet-gateway will now report a degraded state if
a checkin fails. This may not propogate to fleet-server as a failed
checkin means communications between the agent and the server are not
working. It may also lead to the server reporting degraded for up to 30s
(fleet-server polling time) when teh agent is able to successfully
connect.

* linter fix

* add nolint direcrtive

* Linter fix

* Review feedback, add doc strings

* Rename noop controller file to _test file

* [Automation] Update elastic stack version to 8.4.0-722a7d79 for testing (#607)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: enable flaky test detector (#605)

* [Automation] Update elastic stack version to 8.4.0-210dd487 for testing (#620)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* mergify: remove backport automation for non active branches (#615)

* chore: use elastic-agent profile to run the E2E tests (#610)

* [Automation] Update elastic stack version to 8.4.0-a6aa9f3b for testing (#631)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* add macros pointing to new agent's repo and fix old macro calls (#458)

* Add mount of /etc/machine-id for managed Agent in k8s (#530)

* Set hostPID=true for managed agent in k8s (#528)

* Set hostPID=true for managed agent in k8s

* Add comment on hostPID.

* [Automation] Update elastic stack version to 8.4.0-86cc80f3 for testing (#648)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Update elastic-agent-libs version: includes restriction on default VerificationMode to `full` (#521)

* update version

* mage fmt update

* update dependency

* update changelog

* redact sensitive information in diagnostics collect command (#566)

* Support Cloudbeat regex input type  (#638)

* support input type with regex

* Update supported.go

* Changing the regex to support backward compatible

* Disable flaky test download test (#641)

* [Automation] Update elastic stack version to 8.4.0-3d206b5d for testing (#656)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-3ad82aa8 for testing (#661)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* jjbb: exclude allowed branches, tags and PRs (#658)

cosmetic change in the description and boolean based

* Update elastic-agent-project-board.yml (#649)

* ci: fix labels that clashes with the Orka workers (#659)

* [Automation] Update elastic stack version to 8.4.0-03bd6f3f for testing (#668)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-533f1e30 for testing (#675)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Osquerybeat: Fix osquerybeat is not running with logstash output (#674)

* [Automation] Update elastic stack version to 8.4.0-d0a4da44 for testing (#684)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-dd98ded4 for testing (#703)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-164d9a10 for testing (#705)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add missing license headers (#711)

* [Automation] Update elastic stack version to 8.4.0-00048b66 for testing (#713)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Allow - in eql variable names (#710)

* fix to allow dashes in variable names in EQL expressions

extend eql to allow the '-' char to appear in variable names, i.e.,
${data.some-var} and additional test cases to eql, the transpiler, and
the k8s provider to verify this works. Note that the bug was caused by
the EQL limitation, the otehr test cases were added when attempting to
find it.

* Regenerate grammer with antlr 4.7.1, add CHANGELOG

* Fix linter issue

* Fix typo

* Fix transpiler to allow : in dynamic variables. (#680)

Fix transpiler regex to allow ':' characters in dynamic variables so
that users can input "${dynamic.lookup|'fallback.here'}".

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>

* Fix for the filebeat spec file picking up packetbeat inputs (#700)

* Reproduce filebeat picking up packetbeat inputs

* Filebeat: filter inputs as first input transform.

Move input filtering to be the first input transformation that occurs in
the filebeat spec file. Fixes
#427.

* Update changelog.

* [Automation] Update elastic stack version to 8.4.0-3cd57abb for testing (#724)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-a324b98b for testing (#727)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: run on MacOS12 (#696)

* [Automation] Update elastic stack version to 8.4.0-31315ca3 for testing (#732)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* fix typo on package command (#734)

This commit fixes the typo in the package command on the README.md.

* Allow / to be used in variable names (#718)

* Allow the / character to be used in variable names.

Allow / to be used in variable names from dynamic providers and eql
expressions. Ensure that k8s providers can provide variables with
slashes in their names.

* run antlr4

* Fix tests

* Fix Elastic Agent non-fleet broken upgrade between 8.3.x releases (#701)

* Fix Elastic Agent non-fleet broken upgrade between 8.3.x releases

* Migrates vault directory on linux and windows to the top directory of the
  agent, so it can be shared without needing the upgrade handler call,
  like for example with side-by-side install/upgrade from .rpm/.deb
* Extended vault to allow read-only open, useful when the vault at particular location needs to be only read not created.

* Correct the typo in the log messages

* Update lint flagged function comment with 'unused', was flagged with 'deadcode' on the previous run

* Address code review feedback

* Add missing import for linux utz

* Change vault path from Top() to Config(), this a better location, next to fleet.enc based on the install/upgrade testing with .rpm/.deb installs

* Fix the missing state migration for .rpm/.deb upgrade. The post install script now performs the migration and creates the symlink after that.

* Fix typo in the postinstall script

* Update the vault migration code, add the agent configuration match check with the agent secret

* [Automation] Update elastic stack version to 8.4.0-31269fd2 for testing (#746)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* wrap errors and fix some docs typo and convention (#743)

* automate the ironbank docker context generation (#679)

* Update README.md

Adding M1 variable to export to be able to build AMD images

* fix flaky (#730)

* Add filestream ID on standalone kubernetes manifest (#742)

This commit add unique IDs for the filestream inputs used by the
Kubernetes integration in the Elastic-Agent standalone
Kubernetes configuration/manifest file.

* Alter github action to run on different OSs (#769)

Alter the linter action to run on different OSs instead of on linux with
the $GOOS env var.

* [Automation] Update elastic stack version to 8.4.0-d058e92f for testing (#771)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* elastic-agent manifests: add comments; add cloudnative team as a codeowner for the k8s manifests (#708)

* managed elastic-agent: add comments; add cloudnative team as a codeowner for the k8s manifests

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add comments to the standalone elastic-agent, similar to the documentation we have https://www.elastic.co/guide/en/fleet/current/running-on-kubernetes-standalone.html

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* Apply suggestions from code review

Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>

* remove comment for FLEET_ENROLLMENT_TOKEN; use Needed everywhere instead of Required

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* rephrase regarding accessing kube-state-metrics when used third party tools, like kube-rbac-proxy

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* run make check

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* keep manifests in sync to pass ci check

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add info on where to find FLEET_URL and FLEET_ENROLLMENT_TOKEN

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add links to elastic-agent documentation

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* update comment on FLEET_ENROLLMENT_TOKEN

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>

* [Elastic-Agent] Added source uri reloading (#686)

* Update will cleanup unneeded artifacts. (#752)

* Update will cleanup unneeded artifacts.

The update process will cleanup unneeded artifacts. When an update
starts all artifacts that do not have the current version number in it's
name will be removed. If artifact retrieval fails, downloaded artifacts
are removed. On a successful upgrade, all contents of the downloads dir
will be removed.

* Clean up linter warnings

* Wrap errors

* cleanup tests

* Fix passed version

* Use os.RemoveAll

* ci: propagate e2e-testing errors (#695)

* [Release] add-backport-next (#784)

* Update go.sum.

* Fix upgrade.

* Fix the upgrade artifact reload.

* Fix lint in coordinator.

Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com>
Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>
Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Co-authored-by: Daniel Araujo Almeida <daniel-almeida@users.noreply.github.com>
Co-authored-by: Mariana Dima <mariana@elastic.co>
Co-authored-by: ofiriro3 <ofiriro3@Gmail.com>
Co-authored-by: Julien Lind <julien.lind@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
Co-authored-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Write the inspect command for v2.

* Fix lint.

* Fix code review. Load inputs from inputs.d for inspect.

* Fix lint.

* Refactor to use errgroup.

* Remove unused struct.
* Expand check-in payload for V2

* Make linter happy
* Update v2 protocol to use new UnitExpectedConfig.

* Cleanup.

* Update NOTICE.txt. Lint dupl.

* Fix code review. Ensure type is set to real type and not alias.
* Fix bootstrapping a Fleet Server with v2.

* Fix lint.

* Fix tests.
(cherry picked from commit 317e031)

Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
On an M1 Mac rename seems to fail if the containing directories do not
already exist.
* Fix v2 work directory for command. Add permission check for execution. Add determining root into runtime prevention.

* Add writeable by group and other in check.

* Fix restart and stopping issues in command runtime for failing binaries.

* Fix issue in endpoint spec. Allow an input to not require an ID, but that ID must be unique.

* Remove unused transpiler rules and steps.

* Fix test.

* Fix workDir for windows.

* Reset to checkin period.

* Fix test and code review issues.

* Add extra log message in unit test.

* More fixes from code review.

* Fix test.
* Move queue management to dispatcher

Move queue management actions to the dispatcher from the fleet-server
in order to help with future work to add a retry mechanism. Add a
PersistedQueue type which wrap the ActionQueue to make persisting the
queue simpler for the consumer.

* Refactor ActionQueue

Refactor ActionQueue to only export methods that are used by consumers.
The priority queue implementation has been changed to an unexported
type. Persistency has been added and the persistedqueue type has been
removed.

* Rename persistedQueue interface to priorityQueue

* Review feedback

* failing to save queue will log message

* Chagne gateway to use copy
* Fix agent shutdown on SIGINT

* Update runtime_comm expected check-in handling to eliminate the lock in failure cases

* Remove some buffered channels that are not longer blocking shutdown after the runtime comms fix commit

* Fix the recursive lock on itself in the runtime loop, refactored code to make it cleaner

* Fix the comment typo

* Fixed managed_mode coordination with fleet gateway. Now the gateway errors reading loop waits until gateway exits. Otherwise the gateway shutdown out of sequence blocks on errCh

* Fix linter

* Fix make check-ci

* Fix runner Err() possible race

* Update the runer DoneWithTimeout implementation

* Address code review comments
* Add diagnostics back to v2.

* Update pkg/component/runtime/manager.go

Co-authored-by: Anderson Queiroz <me@andersonq.me>

Co-authored-by: Anderson Queiroz <me@andersonq.me>
* Add upgrade action retry

Add the ability for the agent to schedule and retry upgrade actions.

The fleetapi actions now define a ScheduledAction, and RetryableAction interface to eliminate the need for stub methods on all different action types. Action queue has been changed to function on scheduled actions. Serialization tests now ensure that that the retry attribute needed by retryable actions works.

Decouple dispatcher from gateway, dispatcher has an errors channel that will return an error for the list of actions that's sent. Gateway has an Actions method that can be used to get the list of actions from the gateway. The managed_mode config manager will link these two components

If a handler returns an error and the action is a RetryableAction, the dispatcher will attempt to schedule a retry. The dispatcher will also ack the action to fleet-server and indicate if it will be retried or has failed (or has been received normally).
For the acker, if a RetryableAction has an error and an attempt count that is greater than 0 it will be acked as retried. If it has an error and an attempt count less than 1 it will be acked as failed.

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
V1 metrics monitoring for V2 (#1487)
* [Automation] Update elastic stack version to 8.4.0-40cff009 for testing (#557)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-5e6770b1 for testing (#564)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix regression and use comma separated values (#560)

Fix regression from #509

* Change in Jenkinsfile will trigger k8s run (#568)

* [Automation] Update elastic stack version to 8.4.0-da5a1c6d for testing (#573)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add `@metadata.input_id` and `@metadata.stream_id` when injecting streams (#527)

These 2 value are going to be used in the shipper to identify where an
event came from in order to apply processors accordingly.

Also, added test cases for the processor to verify the change and updated test cases with the new processor.

* Add filemod times to contents of diagnostics collect command (#570)

* Add filemod times to contents of diagnostics collect command

Add filemod times to the files and directories in the zip archive.
Log files (and sub dirs) will use the modtime returned by the fileinfo
for the source. Others will use the timestamp from when the zip is
created.

* Fix linter

* [Automation] Update elastic stack version to 8.4.0-b13123ee for testing (#581)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix Agent upgrade 8.2->8.3 (#578)

* Fix Agent upgrade 8.2->8.3
* Improve the upgrade encryption handling. Add .yml files cleanup.
* Rollback ActionUpgrade to action_id, add MarkerActionUpgrade adapter struct for marker serialization compatibility

* Update containerd (#577)

* [Automation] Update elastic stack version to 8.4.0-4fe26f2a for testing (#591)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Set explicit ExitTimeOut for MacOS agent launchd plist (#594)

* Set explicit ExitTimeOut for MacOS agent launchd plist

* [Automation] Update elastic stack version to 8.4.0-2e32a640 for testing (#599)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: enable build notifications as GitHub issues (#595)

* status identifies failing component, fleet gateway may report degraded, liveness endpoint added (#569)

* Add liveness endpoint

Add /liveness route to metrics server. This route will report the status
from pkg/core/status. fleet-gateway will now report a degraded state if
a checkin fails. This may not propogate to fleet-server as a failed
checkin means communications between the agent and the server are not
working. It may also lead to the server reporting degraded for up to 30s
(fleet-server polling time) when teh agent is able to successfully
connect.

* linter fix

* add nolint direcrtive

* Linter fix

* Review feedback, add doc strings

* Rename noop controller file to _test file

* [Automation] Update elastic stack version to 8.4.0-722a7d79 for testing (#607)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: enable flaky test detector (#605)

* [Automation] Update elastic stack version to 8.4.0-210dd487 for testing (#620)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* mergify: remove backport automation for non active branches (#615)

* chore: use elastic-agent profile to run the E2E tests (#610)

* [Automation] Update elastic stack version to 8.4.0-a6aa9f3b for testing (#631)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* add macros pointing to new agent's repo and fix old macro calls (#458)

* Add mount of /etc/machine-id for managed Agent in k8s (#530)

* Set hostPID=true for managed agent in k8s (#528)

* Set hostPID=true for managed agent in k8s

* Add comment on hostPID.

* [Automation] Update elastic stack version to 8.4.0-86cc80f3 for testing (#648)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Update elastic-agent-libs version: includes restriction on default VerificationMode to `full` (#521)

* update version

* mage fmt update

* update dependency

* update changelog

* redact sensitive information in diagnostics collect command (#566)

* Support Cloudbeat regex input type  (#638)

* support input type with regex

* Update supported.go

* Changing the regex to support backward compatible

* Disable flaky test download test (#641)

* [Automation] Update elastic stack version to 8.4.0-3d206b5d for testing (#656)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-3ad82aa8 for testing (#661)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* jjbb: exclude allowed branches, tags and PRs (#658)

cosmetic change in the description and boolean based

* Update elastic-agent-project-board.yml (#649)

* ci: fix labels that clashes with the Orka workers (#659)

* [Automation] Update elastic stack version to 8.4.0-03bd6f3f for testing (#668)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-533f1e30 for testing (#675)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Osquerybeat: Fix osquerybeat is not running with logstash output (#674)

* [Automation] Update elastic stack version to 8.4.0-d0a4da44 for testing (#684)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-dd98ded4 for testing (#703)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-164d9a10 for testing (#705)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add missing license headers (#711)

* [Automation] Update elastic stack version to 8.4.0-00048b66 for testing (#713)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Allow - in eql variable names (#710)

* fix to allow dashes in variable names in EQL expressions

extend eql to allow the '-' char to appear in variable names, i.e.,
${data.some-var} and additional test cases to eql, the transpiler, and
the k8s provider to verify this works. Note that the bug was caused by
the EQL limitation, the otehr test cases were added when attempting to
find it.

* Regenerate grammer with antlr 4.7.1, add CHANGELOG

* Fix linter issue

* Fix typo

* Fix transpiler to allow : in dynamic variables. (#680)

Fix transpiler regex to allow ':' characters in dynamic variables so
that users can input "${dynamic.lookup|'fallback.here'}".

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>

* Fix for the filebeat spec file picking up packetbeat inputs (#700)

* Reproduce filebeat picking up packetbeat inputs

* Filebeat: filter inputs as first input transform.

Move input filtering to be the first input transformation that occurs in
the filebeat spec file. Fixes
#427.

* Update changelog.

* [Automation] Update elastic stack version to 8.4.0-3cd57abb for testing (#724)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-a324b98b for testing (#727)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: run on MacOS12 (#696)

* [Automation] Update elastic stack version to 8.4.0-31315ca3 for testing (#732)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* fix typo on package command (#734)

This commit fixes the typo in the package command on the README.md.

* Allow / to be used in variable names (#718)

* Allow the / character to be used in variable names.

Allow / to be used in variable names from dynamic providers and eql
expressions. Ensure that k8s providers can provide variables with
slashes in their names.

* run antlr4

* Fix tests

* Fix Elastic Agent non-fleet broken upgrade between 8.3.x releases (#701)

* Fix Elastic Agent non-fleet broken upgrade between 8.3.x releases

* Migrates vault directory on linux and windows to the top directory of the
  agent, so it can be shared without needing the upgrade handler call,
  like for example with side-by-side install/upgrade from .rpm/.deb
* Extended vault to allow read-only open, useful when the vault at particular location needs to be only read not created.

* Correct the typo in the log messages

* Update lint flagged function comment with 'unused', was flagged with 'deadcode' on the previous run

* Address code review feedback

* Add missing import for linux utz

* Change vault path from Top() to Config(), this a better location, next to fleet.enc based on the install/upgrade testing with .rpm/.deb installs

* Fix the missing state migration for .rpm/.deb upgrade. The post install script now performs the migration and creates the symlink after that.

* Fix typo in the postinstall script

* Update the vault migration code, add the agent configuration match check with the agent secret

* [Automation] Update elastic stack version to 8.4.0-31269fd2 for testing (#746)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* wrap errors and fix some docs typo and convention (#743)

* automate the ironbank docker context generation (#679)

* Update README.md

Adding M1 variable to export to be able to build AMD images

* fix flaky (#730)

* Add filestream ID on standalone kubernetes manifest (#742)

This commit add unique IDs for the filestream inputs used by the
Kubernetes integration in the Elastic-Agent standalone
Kubernetes configuration/manifest file.

* Alter github action to run on different OSs (#769)

Alter the linter action to run on different OSs instead of on linux with
the $GOOS env var.

* [Automation] Update elastic stack version to 8.4.0-d058e92f for testing (#771)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* elastic-agent manifests: add comments; add cloudnative team as a codeowner for the k8s manifests (#708)

* managed elastic-agent: add comments; add cloudnative team as a codeowner for the k8s manifests

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add comments to the standalone elastic-agent, similar to the documentation we have https://www.elastic.co/guide/en/fleet/current/running-on-kubernetes-standalone.html

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* Apply suggestions from code review

Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>

* remove comment for FLEET_ENROLLMENT_TOKEN; use Needed everywhere instead of Required

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* rephrase regarding accessing kube-state-metrics when used third party tools, like kube-rbac-proxy

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* run make check

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* keep manifests in sync to pass ci check

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add info on where to find FLEET_URL and FLEET_ENROLLMENT_TOKEN

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add links to elastic-agent documentation

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* update comment on FLEET_ENROLLMENT_TOKEN

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>

* [Elastic-Agent] Added source uri reloading (#686)

* Update will cleanup unneeded artifacts. (#752)

* Update will cleanup unneeded artifacts.

The update process will cleanup unneeded artifacts. When an update
starts all artifacts that do not have the current version number in it's
name will be removed. If artifact retrieval fails, downloaded artifacts
are removed. On a successful upgrade, all contents of the downloads dir
will be removed.

* Clean up linter warnings

* Wrap errors

* cleanup tests

* Fix passed version

* Use os.RemoveAll

* ci: propagate e2e-testing errors (#695)

* [Release] add-backport-next (#784)

* Update main to 8.5.0 (#793)

* [Automation] Update go release version to 1.17.12 (#726)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-60171339 for testing (#799)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* update dependency elastic/go-structform from v0.0.9 to v0.0.10 (#802)

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Fix unpacking of artifact config (#776)

Fix unpacking of artifact config (#776)

* [Automation] Update elastic stack version to 8.5.0-c54c3404 for testing (#826)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-7dbc10f8 for testing (#833)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix RPM/DEB clean install (#816)

* Fix RPM/DEB clean install

* Improve the post install script

* Do not try to copy the state files if the agent directory is the same,
  this causes the error.
* Check the existance of symlink instead of the file it is pointing to
  for the state file migration.

* Update check for symlink existance for the cases where the symlink points to non-existent file

* fix path for auto generated spec file (#859)

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Reload downloader client on config change (#848)

Reload downloader client on config change (#848)

* Bundle elastic-agent.app for MacOS, needed to be able to enable the  … (#714)

* Bundle elastic-agent.app for MacOS, needed to be able to enable the  Full Disk Access

* Calm down the linter

* Fix pathing for windows unit test

* crossbuild: add fix to set ulimit for debian images (#856)

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* [Heartbeat] Cleanup docker install / always add playwright deps (#764)

This is the agent counterpart to elastic/beats#32122

Refactors Dockerfile handling of synthetics deps to rely on playwright install-deps rather than us manually keeping up to date with those. This should fix issues with newer playwrights needing additional deps.

This also cleans up the Dockerfile a good amount, and fixes indentation. Finally, this removes the unused Dockerfile.elastic-agent.tmpl file since agent is now its own repo. It also cleans up some other metadata that no longer does anything.

No changelog is specified because no user facing changes are present.

* [Automation] Update elastic stack version to 8.5.0-41aadc32 for testing (#889)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix/panic with composable renderer (#823)

* Fix a panic with wg passed to the composable object

In the code to retrieve the variables from the configuration files we
need to pass a execution callback, this callback will be called in a
goroutine. This callback can be executed multiple time until the
composable renderer is stopped. There were a problem in the code that
made the callback called multiple time and it made the waitgroup
internal counter to do to a negative values.

This commit change the behavior, it start the composable renderer give
it a callback when the callback receives the variables it will stop the
composable's Run method using the context.

This ensure that the callback will be called a single time and that the
variables are correctly retrieved.

Fixes: #806

* [Automation] Update go release version to 1.18.5 (#832)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-60a4c029 for testing (#899)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add control-plane toleration to Agent K8S manifests. (#864)

* Add toleration to elastic-agent Kubernetes manifests.

The toleration with key node-role.kubernetes.io/control-plane is set to replace
the deprecated toleration with key node-role.kubernetes.io/master which will be
removed by Kubernetes v1.25

* Remove outdated "master" node terminology.

* install mage with go install (#936)

* Cloudnative ci automation (#837)

This commit provides the relevant Jenkins CI automation to open Pull requests to kibana github repository in order to keep Cloud-Native teams manifests in sync with the manifests that are used into Fleet UI.

For full information check #706

Updated .ci/Jenkins file that is triggered upon PR requests of /elastic-agent/deploy/kubernetes/* changes
Updated Makefile to add functionality needed to create the extra files for the new prs to kibana remote repository

* Reduce memory footprint by reordering struct elements (#804)

* Reduce memory footprint by reordering struct elements

* rename struct element for linter

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-6b9f92c0 for testing (#948)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-0616acda for testing (#963)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Clarify that this repo is not only docs (#969)

* Add Filebeat lumberjack input to spec (#959)

Make the lumberjack input available from Agent.

Relates: elastic/beats#32175

* [Automation] Update elastic stack version to 8.5.0-dd6f2bb0 for testing (#978)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-feb644de for testing (#988)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-7783a03c for testing (#1004)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-17b8a62d for testing (#1014)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* update ironbank image product name (#1009)

This is required to automate the creation of the ironbank merge requests as the ubireleaser is using this field to compute the elastic-agent artifact url. 

For example it is now trying to retrieve https://artifacts.elastic.co/downloads/beats/elastic-agent-8.4.0-linux-x86_64.tar.gz instead of https://artifacts.elastic.co/downloads/beats/elastic-agent/elastic-agent-8.4.0-linux-x86_64.tar.gz

* ci: add extended support for windows (#683)

* [Automation] Update elastic stack version to 8.5.0-9aed3b11 for testing (#1030)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Cloudnative ci utomation (#1035)

* Updating Jenkinsfile and Makefile to open PR

* Adding needed token-id

* [Automation] Update elastic stack version to 8.5.0-fedc3e60 for testing (#1054)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Testing PR creation for 706 (#1049)

* Fix lookup issues with inputs.d fragment yml (#840)

* Fix lookup issues with inputs.d fragment yml

The Elastic Agent was looking next to the binary for the `inputs.d`
folder instead it should look up into the `Home` folder where
the Elastic Agent symlink is located.

Fixes: #663

* Changelog

* Fix input.d path, tie to the agent Config() directory

* Update CHANGELOG to reflect that the agent configuration directory is used to locate the inputs.d directory

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-b5001a6d for testing (#1064)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-1bd77fc1 for testing (#1082)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-167dfc80 for testing (#1091)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Adding support for v1.25.0 k8s (#1044)

* Adding support for v1.25.0 k8s

* [Automation] Update elastic stack version to 8.5.0-6b7dda2d for testing (#1101)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-4140365c for testing (#1114)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Remove experimental warning log in upgrade command (#1106)

* Update go.mod to Go 1.18, update notice. (#1120)

* Remove the fleet reporter (#1130)

* Remove the fleet reporter

Remove the fleet-reporter so that checkins no longer deliver the event
list.

* add CHANGELOG fix tests

* [Automation] Update elastic stack version to 8.5.0-589a4a10 for testing (#1147)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Avoid reporting `Unhealthy` on fleet connectivity issues (#1152)

Avoid reporting `Unhealthy` on fleet connectivity issues (#1152)

* ci: enable MacOS M1 stages (#1123)

* [Automation] Update go release version to 1.18.6 (#1143)

* [Automation] Update elastic stack version to 8.5.0-37418cf3 for testing (#1165)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Remove mage notice in favour of make notice (#1108)

The current implementation of mage notice is not working because it
was never finalised, the fact that it and `make notice` exist only
generates confusion.

This commit removes the `mage notice` and documents that `make notice`
should be used instead for the time being.

In the long run we want to use the implementation on
`elastic-agent-libs`, however it is not working at the moment.

Closes #1107

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* ci: run e2e-testing at the end (#1169)

* ci: move macos to github actions (#1175)

* [Automation] Update elastic stack version to 8.5.0-fcf3d4c2 for testing (#1183)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add support for hints' based autodiscovery in kubernetes provider (#698)

* ci: increase timeout (#1190)

* Fixing condition for PR creation (#1188)

* Fix leftover log level (#1194)

* [automation] Publish kubernetes templates for elastic-agent (#1192)

Co-authored-by: apmmachine <infra-root+apmmachine@elastic.co>

* ci: force GO_VERSION (#1204)

* Fix whitespaces in vault_darwin.c (#1206)

* Update kubernetes templates for elastic-agent [templates.d] (#1231)

* Use at least warning level for all status logs (#1218)

* Update k8s manifests to leverage hints (#1202)

* Add Go 1.18 upgrade to breaking changes section. (#1216)

* Add Go 1.18 upgrade to breaking changes section.

* Fix the PR number in the changelog.

* [Release] add-backport-next (#1254)

* Bump version to 8.6.0. (#1259)

* [Automation] Update elastic stack version to 8.5.0-7dc445a0 for testing (#1248)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix: Endpoint collision between monitoring and regular beats  (#1034)

Fix: Endpoint collision between monitoring and regular beats  (#1034)

* internal/pkg/agent/cmd: don't format error message with nil errors (#1240)

The failure conditions allow nil errors to result in an error being formatted,
when formatting due to a non-accepted HTTP status code and a nil error, omit the
error.

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-21651da3 for testing (#1290)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fixed: source uri reload for download/verify components (#1252)

Fixed: source uri reload for download/verify components (#1252)

* Expand status reporter/controller interfaces to allow local reporters (#1285)

* Expand status reporter/controller interfaces to allow local reporters

Add a local reporter map to the status controller. These reporters are
not used when updating status with fleet-server, they are only used to
gather local state information - specifically if the agent is degraded
because checkin with fleet-server has failed. This bypasses the bug that
was introduced with the liveness endpoint where the agent could checkin
(to fleet-server) with a degraded status because a previous checkin
failed. Local reporters are used to generate a separate status. This
status is used in the liveness endpoint.

* fix linter

* Improve logging for agent upgrades. (#1287)

* [Automation] Update elastic stack version to 8.6.0-326f84b0 for testing (#1318)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-df00693f for testing (#1334)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add success log message after previous checkin failures (#1327)

* Fix status reporter initialization (#1341)

* [Automation] Update elastic stack version to 8.6.0-a2f4f140 for testing (#1362)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Added status message to CheckinRequest (#1369)

* Added status message to CheckinRequest

* added changelog

* updated test

* added omitempty

* Fix failures when using npipe monitoring endpoints (#1371)

* [Automation] Update elastic stack version to 8.6.0-158a13db for testing (#1379)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Mount /etc directory in Kubernetes DaemonSet manifests. (#1382)

Changes made to files like `/etc/passwd` using Linux tools like
`useradd` are not reflected in the mounted file on the Agent,
because the tool replaces the file instead of changing it
in-place.

Mounting the parent directory solves this problem.

* [Automation] Update elastic stack version to 8.6.0-aea1c645 for testing (#1405)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-0fca2953 for testing (#1412)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: 7.17 is not available for the daily run (#1417)

* [Automation] Update elastic stack version to 8.6.0-e4c15f15 for testing (#1425)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [backport main] Fix: Agent failed to upgrade from 8.4.2 to 8.5.0 BC1 for MAC 12 agent using agent binary. (#1401)

[backport main] Fix: Agent failed to upgrade from 8.4.2 to 8.5.0 BC1 for MAC 12 agent using agent binary. (#1401)

* Fix docker provider add_fields processors (#1420)

The Docker provider was using a wrong key when defining the
`add_fields` processor, this causes Filebeat not to start the input
and stay on a unhealthy state.

This commig fixes it.

Fixes elastic/beats#29030

* [Automation] Update elastic stack version to 8.6.0-d939cfde for testing (#1436)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-7c9f25a9 for testing (#1446)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Enable integration only when datastreams are not defined (#1456)

* Add not dedoted k8s pod labels in autodiscover provider to be used for templating, exactly like annotations (#1398)

* [Automation] Update elastic stack version to 8.6.0-c49fac70 for testing (#1464)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add storageclass permissions in agent clusterrole (#1470)

* Add storageclass permissions in agent clusterrole

* Remote QA-labels automation (#1455)

* [Automation] Update go release version to 1.18.7 (#1444)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-5a8d757d for testing (#1480)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Improve logging around agent checkins. (#1477)

Improve logging around agent checkins.

- Log transient checkin errors at Info.
- Upgrade to an Error log after 2 repeated failures.
- Log the wait time for the next retry.
- Only update local state after repeated failures.

* [Automation] Update elastic stack version to 8.6.0-40086bc7 for testing (#1496)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fixing makefile check (#1490)

* Fixing makefile check

* action: validate changelog fragment (#1488)

* Allign managed with standalone role (#1500)

* Fix k8s template link versioning (#1504)

* Allighningmanifests (#1507)

* Allign managed with standalone role

* Fixing missing Label

* [Automation] Update elastic stack version to 8.6.0-233dc5d4 for testing (#1515)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Convert CHANGELOG.next to fragments (#1244)

* [Automation] Update elastic stack version to 8.6.0-54a302f0 for testing (#1531)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Update the linter configuration. (#1478)

Sync the configuration with the one used in Beats, which has disabled
the majority of the least useful linters already.

* Elastic agent counterpart of elastic/beats#33362 (#1528)

Always use the stack_release label for npm i

No changelog necessary since there are no user-visible changes

This lets us ensure we've carefully reviewed and labeled the version of the @elastic/synthetics NPM library that's bundled in docker images

* [Automation] Update elastic stack version to 8.6.0-cae815eb for testing (#1545)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix admin permission check on localized windows (#1552)

Fix admin permission check on localized windows (#1552)

* Fixes from merge of main.

* Update heartbeat specification to only support elasticsearch.

* Fix bad merge in dockerfile.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com>
Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>
Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Co-authored-by: Daniel Araujo Almeida <daniel-almeida@users.noreply.github.com>
Co-authored-by: Mariana Dima <mariana@elastic.co>
Co-authored-by: ofiriro3 <ofiriro3@Gmail.com>
Co-authored-by: Julien Lind <julien.lind@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
Co-authored-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
Co-authored-by: Andrew Cholakian <andrewvc@elastic.co>
Co-authored-by: Yash Tewari <yashtewari1996@gmail.com>
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
Co-authored-by: apmmachine <infra-root+apmmachine@elastic.co>
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
* add name alias for cloudbeat

* add anchors for yaml fields

* add EKS input
michel-laterman and others added 6 commits October 24, 2022 15:11
* Change the stater to include a local flag.

Change the state reporter to use a local flag that determines if local
errors are included in the resulting state. Assume that configMgr errors
are all local - this effects mainly the fleet_gateway. Allow the gateway
to report an error if a checkin fails. When a checkin fails the local
state reported through the status command and liveness endpoint will
include the error, but checkins to fleet-server will not.

* Add ActionsError() method to config manager

Add a new ActionsError() methdo the the config managers. For the
non-managed instances it will return a nil channel. For the managed
instances it will return the dispatcher error queue directly. Have teh
coordinator gather from this channel as it does for the others and
treat any errors as non-local.

* Fix linter
* Service V2 runtime

* Implements service runtime component for V2.
* Extends endpoint spec with some additional attributes for service start/stop/status checks and creds discovery. The creds discovery logic is taken from V1, cleaned up and extracted into its own file, added utz.
* Implements service uninstall
* Refactors pkg/core/process/process.go adds additional options that are needed for the service_command implementation.
* Changes ComponentsModifier to access raw config, needed for the EndpointComponentModifier
* Injects host.id into configuration, needed for Endpoint
* Injects fleet and policy.revision configuration into the Endpoint input configuration
* Bumps the version to 8.6.0 to make it consistent with current beats V2 branch
* Addresses linter complains on affected files

* Remove the service watcher, all the start/stopping logic

* Add changelog

* Fix typo

* Send STOPPING only upon teardown

* Wait for check-in with timeout before sending stopping on teardown

* Fix the service loop routine blocking on channel after stopped

* Addressed code review comments

* Make linter happy

* Try to fix make check-ci

* Spellcheck runtime README.md

* Remove .Stop timeout from the spec as it is no longer used

* Addressed code review feedback
* Sync components with state during container start

* path approach
* Work on adding shipper support.

* Fix fmt.

* Fix reference to spec. Allow shipper to be null but still enabled if key exists.

* Move supported shippers into its own key in the input specification.

* Fix issue in merge.

* Implement fake shipper and add fake shipper output to the fake component.

* Add protoc to the test target.

* Don't generate fake shipper protocol in test.

* Commit fake GRPC into code.

* Add unit test for running with shipper, with sending event between running componentn and running shipper.

* Add docstring for shipper test.

* Add changelog fragement.

* Adjust paths for shipper to work on windows and better on unix.

* Update changelog/fragments/1667571017-Add-support-for-running-the-elastic-agent-shipper.yaml

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* Fix fake/component to connect over npipe on windows.

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
* [Automation] Update elastic stack version to 8.4.0-40cff009 for testing (#557)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-5e6770b1 for testing (#564)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix regression and use comma separated values (#560)

Fix regression from #509

* Change in Jenkinsfile will trigger k8s run (#568)

* [Automation] Update elastic stack version to 8.4.0-da5a1c6d for testing (#573)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add `@metadata.input_id` and `@metadata.stream_id` when injecting streams (#527)

These 2 value are going to be used in the shipper to identify where an
event came from in order to apply processors accordingly.

Also, added test cases for the processor to verify the change and updated test cases with the new processor.

* Add filemod times to contents of diagnostics collect command (#570)

* Add filemod times to contents of diagnostics collect command

Add filemod times to the files and directories in the zip archive.
Log files (and sub dirs) will use the modtime returned by the fileinfo
for the source. Others will use the timestamp from when the zip is
created.

* Fix linter

* [Automation] Update elastic stack version to 8.4.0-b13123ee for testing (#581)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix Agent upgrade 8.2->8.3 (#578)

* Fix Agent upgrade 8.2->8.3
* Improve the upgrade encryption handling. Add .yml files cleanup.
* Rollback ActionUpgrade to action_id, add MarkerActionUpgrade adapter struct for marker serialization compatibility

* Update containerd (#577)

* [Automation] Update elastic stack version to 8.4.0-4fe26f2a for testing (#591)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Set explicit ExitTimeOut for MacOS agent launchd plist (#594)

* Set explicit ExitTimeOut for MacOS agent launchd plist

* [Automation] Update elastic stack version to 8.4.0-2e32a640 for testing (#599)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: enable build notifications as GitHub issues (#595)

* status identifies failing component, fleet gateway may report degraded, liveness endpoint added (#569)

* Add liveness endpoint

Add /liveness route to metrics server. This route will report the status
from pkg/core/status. fleet-gateway will now report a degraded state if
a checkin fails. This may not propogate to fleet-server as a failed
checkin means communications between the agent and the server are not
working. It may also lead to the server reporting degraded for up to 30s
(fleet-server polling time) when teh agent is able to successfully
connect.

* linter fix

* add nolint direcrtive

* Linter fix

* Review feedback, add doc strings

* Rename noop controller file to _test file

* [Automation] Update elastic stack version to 8.4.0-722a7d79 for testing (#607)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: enable flaky test detector (#605)

* [Automation] Update elastic stack version to 8.4.0-210dd487 for testing (#620)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* mergify: remove backport automation for non active branches (#615)

* chore: use elastic-agent profile to run the E2E tests (#610)

* [Automation] Update elastic stack version to 8.4.0-a6aa9f3b for testing (#631)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* add macros pointing to new agent's repo and fix old macro calls (#458)

* Add mount of /etc/machine-id for managed Agent in k8s (#530)

* Set hostPID=true for managed agent in k8s (#528)

* Set hostPID=true for managed agent in k8s

* Add comment on hostPID.

* [Automation] Update elastic stack version to 8.4.0-86cc80f3 for testing (#648)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Update elastic-agent-libs version: includes restriction on default VerificationMode to `full` (#521)

* update version

* mage fmt update

* update dependency

* update changelog

* redact sensitive information in diagnostics collect command (#566)

* Support Cloudbeat regex input type  (#638)

* support input type with regex

* Update supported.go

* Changing the regex to support backward compatible

* Disable flaky test download test (#641)

* [Automation] Update elastic stack version to 8.4.0-3d206b5d for testing (#656)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-3ad82aa8 for testing (#661)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* jjbb: exclude allowed branches, tags and PRs (#658)

cosmetic change in the description and boolean based

* Update elastic-agent-project-board.yml (#649)

* ci: fix labels that clashes with the Orka workers (#659)

* [Automation] Update elastic stack version to 8.4.0-03bd6f3f for testing (#668)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-533f1e30 for testing (#675)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Osquerybeat: Fix osquerybeat is not running with logstash output (#674)

* [Automation] Update elastic stack version to 8.4.0-d0a4da44 for testing (#684)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-dd98ded4 for testing (#703)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-164d9a10 for testing (#705)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add missing license headers (#711)

* [Automation] Update elastic stack version to 8.4.0-00048b66 for testing (#713)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Allow - in eql variable names (#710)

* fix to allow dashes in variable names in EQL expressions

extend eql to allow the '-' char to appear in variable names, i.e.,
${data.some-var} and additional test cases to eql, the transpiler, and
the k8s provider to verify this works. Note that the bug was caused by
the EQL limitation, the otehr test cases were added when attempting to
find it.

* Regenerate grammer with antlr 4.7.1, add CHANGELOG

* Fix linter issue

* Fix typo

* Fix transpiler to allow : in dynamic variables. (#680)

Fix transpiler regex to allow ':' characters in dynamic variables so
that users can input "${dynamic.lookup|'fallback.here'}".

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>

* Fix for the filebeat spec file picking up packetbeat inputs (#700)

* Reproduce filebeat picking up packetbeat inputs

* Filebeat: filter inputs as first input transform.

Move input filtering to be the first input transformation that occurs in
the filebeat spec file. Fixes
#427.

* Update changelog.

* [Automation] Update elastic stack version to 8.4.0-3cd57abb for testing (#724)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-a324b98b for testing (#727)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: run on MacOS12 (#696)

* [Automation] Update elastic stack version to 8.4.0-31315ca3 for testing (#732)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* fix typo on package command (#734)

This commit fixes the typo in the package command on the README.md.

* Allow / to be used in variable names (#718)

* Allow the / character to be used in variable names.

Allow / to be used in variable names from dynamic providers and eql
expressions. Ensure that k8s providers can provide variables with
slashes in their names.

* run antlr4

* Fix tests

* Fix Elastic Agent non-fleet broken upgrade between 8.3.x releases (#701)

* Fix Elastic Agent non-fleet broken upgrade between 8.3.x releases

* Migrates vault directory on linux and windows to the top directory of the
  agent, so it can be shared without needing the upgrade handler call,
  like for example with side-by-side install/upgrade from .rpm/.deb
* Extended vault to allow read-only open, useful when the vault at particular location needs to be only read not created.

* Correct the typo in the log messages

* Update lint flagged function comment with 'unused', was flagged with 'deadcode' on the previous run

* Address code review feedback

* Add missing import for linux utz

* Change vault path from Top() to Config(), this a better location, next to fleet.enc based on the install/upgrade testing with .rpm/.deb installs

* Fix the missing state migration for .rpm/.deb upgrade. The post install script now performs the migration and creates the symlink after that.

* Fix typo in the postinstall script

* Update the vault migration code, add the agent configuration match check with the agent secret

* [Automation] Update elastic stack version to 8.4.0-31269fd2 for testing (#746)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* wrap errors and fix some docs typo and convention (#743)

* automate the ironbank docker context generation (#679)

* Update README.md

Adding M1 variable to export to be able to build AMD images

* fix flaky (#730)

* Add filestream ID on standalone kubernetes manifest (#742)

This commit add unique IDs for the filestream inputs used by the
Kubernetes integration in the Elastic-Agent standalone
Kubernetes configuration/manifest file.

* Alter github action to run on different OSs (#769)

Alter the linter action to run on different OSs instead of on linux with
the $GOOS env var.

* [Automation] Update elastic stack version to 8.4.0-d058e92f for testing (#771)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* elastic-agent manifests: add comments; add cloudnative team as a codeowner for the k8s manifests (#708)

* managed elastic-agent: add comments; add cloudnative team as a codeowner for the k8s manifests

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add comments to the standalone elastic-agent, similar to the documentation we have https://www.elastic.co/guide/en/fleet/current/running-on-kubernetes-standalone.html

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* Apply suggestions from code review

Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>

* remove comment for FLEET_ENROLLMENT_TOKEN; use Needed everywhere instead of Required

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* rephrase regarding accessing kube-state-metrics when used third party tools, like kube-rbac-proxy

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* run make check

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* keep manifests in sync to pass ci check

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add info on where to find FLEET_URL and FLEET_ENROLLMENT_TOKEN

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* add links to elastic-agent documentation

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

* update comment on FLEET_ENROLLMENT_TOKEN

Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>

* [Elastic-Agent] Added source uri reloading (#686)

* Update will cleanup unneeded artifacts. (#752)

* Update will cleanup unneeded artifacts.

The update process will cleanup unneeded artifacts. When an update
starts all artifacts that do not have the current version number in it's
name will be removed. If artifact retrieval fails, downloaded artifacts
are removed. On a successful upgrade, all contents of the downloads dir
will be removed.

* Clean up linter warnings

* Wrap errors

* cleanup tests

* Fix passed version

* Use os.RemoveAll

* ci: propagate e2e-testing errors (#695)

* [Release] add-backport-next (#784)

* Update main to 8.5.0 (#793)

* [Automation] Update go release version to 1.17.12 (#726)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.4.0-60171339 for testing (#799)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* update dependency elastic/go-structform from v0.0.9 to v0.0.10 (#802)

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Fix unpacking of artifact config (#776)

Fix unpacking of artifact config (#776)

* [Automation] Update elastic stack version to 8.5.0-c54c3404 for testing (#826)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-7dbc10f8 for testing (#833)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix RPM/DEB clean install (#816)

* Fix RPM/DEB clean install

* Improve the post install script

* Do not try to copy the state files if the agent directory is the same,
  this causes the error.
* Check the existance of symlink instead of the file it is pointing to
  for the state file migration.

* Update check for symlink existance for the cases where the symlink points to non-existent file

* fix path for auto generated spec file (#859)

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* Reload downloader client on config change (#848)

Reload downloader client on config change (#848)

* Bundle elastic-agent.app for MacOS, needed to be able to enable the  … (#714)

* Bundle elastic-agent.app for MacOS, needed to be able to enable the  Full Disk Access

* Calm down the linter

* Fix pathing for windows unit test

* crossbuild: add fix to set ulimit for debian images (#856)

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* [Heartbeat] Cleanup docker install / always add playwright deps (#764)

This is the agent counterpart to elastic/beats#32122

Refactors Dockerfile handling of synthetics deps to rely on playwright install-deps rather than us manually keeping up to date with those. This should fix issues with newer playwrights needing additional deps.

This also cleans up the Dockerfile a good amount, and fixes indentation. Finally, this removes the unused Dockerfile.elastic-agent.tmpl file since agent is now its own repo. It also cleans up some other metadata that no longer does anything.

No changelog is specified because no user facing changes are present.

* [Automation] Update elastic stack version to 8.5.0-41aadc32 for testing (#889)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix/panic with composable renderer (#823)

* Fix a panic with wg passed to the composable object

In the code to retrieve the variables from the configuration files we
need to pass a execution callback, this callback will be called in a
goroutine. This callback can be executed multiple time until the
composable renderer is stopped. There were a problem in the code that
made the callback called multiple time and it made the waitgroup
internal counter to do to a negative values.

This commit change the behavior, it start the composable renderer give
it a callback when the callback receives the variables it will stop the
composable's Run method using the context.

This ensure that the callback will be called a single time and that the
variables are correctly retrieved.

Fixes: #806

* [Automation] Update go release version to 1.18.5 (#832)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-60a4c029 for testing (#899)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add control-plane toleration to Agent K8S manifests. (#864)

* Add toleration to elastic-agent Kubernetes manifests.

The toleration with key node-role.kubernetes.io/control-plane is set to replace
the deprecated toleration with key node-role.kubernetes.io/master which will be
removed by Kubernetes v1.25

* Remove outdated "master" node terminology.

* install mage with go install (#936)

* Cloudnative ci automation (#837)

This commit provides the relevant Jenkins CI automation to open Pull requests to kibana github repository in order to keep Cloud-Native teams manifests in sync with the manifests that are used into Fleet UI.

For full information check #706

Updated .ci/Jenkins file that is triggered upon PR requests of /elastic-agent/deploy/kubernetes/* changes
Updated Makefile to add functionality needed to create the extra files for the new prs to kibana remote repository

* Reduce memory footprint by reordering struct elements (#804)

* Reduce memory footprint by reordering struct elements

* rename struct element for linter

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-6b9f92c0 for testing (#948)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-0616acda for testing (#963)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Clarify that this repo is not only docs (#969)

* Add Filebeat lumberjack input to spec (#959)

Make the lumberjack input available from Agent.

Relates: elastic/beats#32175

* [Automation] Update elastic stack version to 8.5.0-dd6f2bb0 for testing (#978)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-feb644de for testing (#988)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-7783a03c for testing (#1004)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-17b8a62d for testing (#1014)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* update ironbank image product name (#1009)

This is required to automate the creation of the ironbank merge requests as the ubireleaser is using this field to compute the elastic-agent artifact url. 

For example it is now trying to retrieve https://artifacts.elastic.co/downloads/beats/elastic-agent-8.4.0-linux-x86_64.tar.gz instead of https://artifacts.elastic.co/downloads/beats/elastic-agent/elastic-agent-8.4.0-linux-x86_64.tar.gz

* ci: add extended support for windows (#683)

* [Automation] Update elastic stack version to 8.5.0-9aed3b11 for testing (#1030)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Cloudnative ci utomation (#1035)

* Updating Jenkinsfile and Makefile to open PR

* Adding needed token-id

* [Automation] Update elastic stack version to 8.5.0-fedc3e60 for testing (#1054)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Testing PR creation for 706 (#1049)

* Fix lookup issues with inputs.d fragment yml (#840)

* Fix lookup issues with inputs.d fragment yml

The Elastic Agent was looking next to the binary for the `inputs.d`
folder instead it should look up into the `Home` folder where
the Elastic Agent symlink is located.

Fixes: #663

* Changelog

* Fix input.d path, tie to the agent Config() directory

* Update CHANGELOG to reflect that the agent configuration directory is used to locate the inputs.d directory

Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-b5001a6d for testing (#1064)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-1bd77fc1 for testing (#1082)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-167dfc80 for testing (#1091)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Adding support for v1.25.0 k8s (#1044)

* Adding support for v1.25.0 k8s

* [Automation] Update elastic stack version to 8.5.0-6b7dda2d for testing (#1101)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.5.0-4140365c for testing (#1114)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Remove experimental warning log in upgrade command (#1106)

* Update go.mod to Go 1.18, update notice. (#1120)

* Remove the fleet reporter (#1130)

* Remove the fleet reporter

Remove the fleet-reporter so that checkins no longer deliver the event
list.

* add CHANGELOG fix tests

* [Automation] Update elastic stack version to 8.5.0-589a4a10 for testing (#1147)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Avoid reporting `Unhealthy` on fleet connectivity issues (#1152)

Avoid reporting `Unhealthy` on fleet connectivity issues (#1152)

* ci: enable MacOS M1 stages (#1123)

* [Automation] Update go release version to 1.18.6 (#1143)

* [Automation] Update elastic stack version to 8.5.0-37418cf3 for testing (#1165)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Remove mage notice in favour of make notice (#1108)

The current implementation of mage notice is not working because it
was never finalised, the fact that it and `make notice` exist only
generates confusion.

This commit removes the `mage notice` and documents that `make notice`
should be used instead for the time being.

In the long run we want to use the implementation on
`elastic-agent-libs`, however it is not working at the moment.

Closes #1107

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* ci: run e2e-testing at the end (#1169)

* ci: move macos to github actions (#1175)

* [Automation] Update elastic stack version to 8.5.0-fcf3d4c2 for testing (#1183)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add support for hints' based autodiscovery in kubernetes provider (#698)

* ci: increase timeout (#1190)

* Fixing condition for PR creation (#1188)

* Fix leftover log level (#1194)

* [automation] Publish kubernetes templates for elastic-agent (#1192)

Co-authored-by: apmmachine <infra-root+apmmachine@elastic.co>

* ci: force GO_VERSION (#1204)

* Fix whitespaces in vault_darwin.c (#1206)

* Update kubernetes templates for elastic-agent [templates.d] (#1231)

* Use at least warning level for all status logs (#1218)

* Update k8s manifests to leverage hints (#1202)

* Add Go 1.18 upgrade to breaking changes section. (#1216)

* Add Go 1.18 upgrade to breaking changes section.

* Fix the PR number in the changelog.

* [Release] add-backport-next (#1254)

* Bump version to 8.6.0. (#1259)

* [Automation] Update elastic stack version to 8.5.0-7dc445a0 for testing (#1248)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix: Endpoint collision between monitoring and regular beats  (#1034)

Fix: Endpoint collision between monitoring and regular beats  (#1034)

* internal/pkg/agent/cmd: don't format error message with nil errors (#1240)

The failure conditions allow nil errors to result in an error being formatted,
when formatting due to a non-accepted HTTP status code and a nil error, omit the
error.

Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-21651da3 for testing (#1290)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fixed: source uri reload for download/verify components (#1252)

Fixed: source uri reload for download/verify components (#1252)

* Expand status reporter/controller interfaces to allow local reporters (#1285)

* Expand status reporter/controller interfaces to allow local reporters

Add a local reporter map to the status controller. These reporters are
not used when updating status with fleet-server, they are only used to
gather local state information - specifically if the agent is degraded
because checkin with fleet-server has failed. This bypasses the bug that
was introduced with the liveness endpoint where the agent could checkin
(to fleet-server) with a degraded status because a previous checkin
failed. Local reporters are used to generate a separate status. This
status is used in the liveness endpoint.

* fix linter

* Improve logging for agent upgrades. (#1287)

* [Automation] Update elastic stack version to 8.6.0-326f84b0 for testing (#1318)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-df00693f for testing (#1334)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add success log message after previous checkin failures (#1327)

* Fix status reporter initialization (#1341)

* [Automation] Update elastic stack version to 8.6.0-a2f4f140 for testing (#1362)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Added status message to CheckinRequest (#1369)

* Added status message to CheckinRequest

* added changelog

* updated test

* added omitempty

* Fix failures when using npipe monitoring endpoints (#1371)

* [Automation] Update elastic stack version to 8.6.0-158a13db for testing (#1379)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Mount /etc directory in Kubernetes DaemonSet manifests. (#1382)

Changes made to files like `/etc/passwd` using Linux tools like
`useradd` are not reflected in the mounted file on the Agent,
because the tool replaces the file instead of changing it
in-place.

Mounting the parent directory solves this problem.

* [Automation] Update elastic stack version to 8.6.0-aea1c645 for testing (#1405)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-0fca2953 for testing (#1412)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* ci: 7.17 is not available for the daily run (#1417)

* [Automation] Update elastic stack version to 8.6.0-e4c15f15 for testing (#1425)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [backport main] Fix: Agent failed to upgrade from 8.4.2 to 8.5.0 BC1 for MAC 12 agent using agent binary. (#1401)

[backport main] Fix: Agent failed to upgrade from 8.4.2 to 8.5.0 BC1 for MAC 12 agent using agent binary. (#1401)

* Fix docker provider add_fields processors (#1420)

The Docker provider was using a wrong key when defining the
`add_fields` processor, this causes Filebeat not to start the input
and stay on a unhealthy state.

This commig fixes it.

Fixes elastic/beats#29030

* [Automation] Update elastic stack version to 8.6.0-d939cfde for testing (#1436)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-7c9f25a9 for testing (#1446)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Enable integration only when datastreams are not defined (#1456)

* Add not dedoted k8s pod labels in autodiscover provider to be used for templating, exactly like annotations (#1398)

* [Automation] Update elastic stack version to 8.6.0-c49fac70 for testing (#1464)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Add storageclass permissions in agent clusterrole (#1470)

* Add storageclass permissions in agent clusterrole

* Remote QA-labels automation (#1455)

* [Automation] Update go release version to 1.18.7 (#1444)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-5a8d757d for testing (#1480)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Improve logging around agent checkins. (#1477)

Improve logging around agent checkins.

- Log transient checkin errors at Info.
- Upgrade to an Error log after 2 repeated failures.
- Log the wait time for the next retry.
- Only update local state after repeated failures.

* [Automation] Update elastic stack version to 8.6.0-40086bc7 for testing (#1496)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fixing makefile check (#1490)

* Fixing makefile check

* action: validate changelog fragment (#1488)

* Allign managed with standalone role (#1500)

* Fix k8s template link versioning (#1504)

* Allighningmanifests (#1507)

* Allign managed with standalone role

* Fixing missing Label

* [Automation] Update elastic stack version to 8.6.0-233dc5d4 for testing (#1515)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Convert CHANGELOG.next to fragments (#1244)

* [Automation] Update elastic stack version to 8.6.0-54a302f0 for testing (#1531)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Update the linter configuration. (#1478)

Sync the configuration with the one used in Beats, which has disabled
the majority of the least useful linters already.

* Elastic agent counterpart of elastic/beats#33362 (#1528)

Always use the stack_release label for npm i

No changelog necessary since there are no user-visible changes

This lets us ensure we've carefully reviewed and labeled the version of the @elastic/synthetics NPM library that's bundled in docker images

* [Automation] Update elastic stack version to 8.6.0-cae815eb for testing (#1545)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Fix admin permission check on localized windows (#1552)

Fix admin permission check on localized windows (#1552)

* [Automation] Update elastic stack version to 8.6.0-6545f2df for testing (#1561)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Heartbeat] Only support elasticsearch output for synthetics integration (#1491)

* [Heartbeat] Only support elasticsearch output for synthetics integration

Heartbeat should only support the elasticsearch output  due to the requirement that we connect back to ES to retrieve prior state, as well as the complex and exacting nature of our schema.

* Add buildspec
* Add changelog
* Remove test that configures heartbeat+logstash

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>

* make policy change handler try all fleet hosts before failing (#1329)

It changes the remote client to:
 - when creating a new client:
   - succeed if at least one host is health
   - shuffle the hosts, avoiding all the agents reaching to the same fleet-server on the first request
 - makes `(remote.*Client).Send` try all the hosts before failing, returning a multi-error if all hosts fail
   - if debug logs are enabled, `Send` will log each error with debug level
 - modifies `remote.requestClient`:
   - now `requestClient` holds its host
   - remove `requestFunc`
   - `(remopte.requestClient).newRequest uses the new `host` property to build the final URL for the request

* [Automation] Update elastic stack version to 8.6.0-baf193e8 for testing (#1579)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-22d60ec9 for testing (#1587)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [automation] Publish kubernetes templates for elastic-agent (#1594)

Co-authored-by: apmmachine <infra-root+apmmachine@elastic.co>

* Fix: Windows Agent Left Unhealthy After Removing Endpoint Integration (#1286)

* Add stop timeout to the endpoint spec
* Service watcher
* Wire in the service watcher
* Remove waiting on the service stop since Endpoint should not be stopped

* [Automation] Update elastic stack version to 8.6.0-b8b35931 for testing (#1602)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Create stale config (#1607)

Purpose of this is to frequently clean up elastic agent repo

* [Automation] Update elastic stack version to 8.6.0-a892f234 for testing (#1621)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Improve shutdown logs (#1618)

* [Automation] Update elastic stack version to 8.6.0-89d224d2 for testing (#1633)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Add GH action to add issues to ingest board (#1629)

* Add GH action to add issues to ingest board

Issues labeled w/ the control plane or data plane labels in this repository will be added to the ingest project w/ `Area: Elastic Agent` set

* Support Elastic Agent label

* Update add-issues-to-ingest-board.yml

* Update add-issues-to-ingest-board.yml

* Update add-issues-to-ingest-board.yml

* [Automation] Update elastic stack version to 8.6.0-949a38d2 for testing (#1647)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Update node version to 18.12.0 on complete image (#1657)

This puts us on to the latest LTS release of node.

Test by using a private location with Uptime to run a browser monitor.

* [Automation] Update elastic stack version to 8.6.0-26dc1164 for testing (#1660)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Generate the consolidated 8.5.0 changelog. (#1642) (#1670)

* Consolidate the 8.5.0 changelog fragments.

Generate a summarized YAML file of all the changes in 8.5.0 for future
reference. The rendered changelog lives in the observability-docs
repository currently.

* Improve README documentation for the changelog.

* [Automation] Update elastic stack version to 8.6.0-4765d2b0 for testing (#1674)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Disable creating GH issues for build failures. (#1677)

The E2E tests are still unstable and the issues reported for those
failures is creating a lot of noise in the issue tracker.

* [Automation] Update elastic stack version to 8.6.0-8a615646 for testing (#1682)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update elastic stack version to 8.6.0-3f5f98b7 for testing (#1685)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Remove non-agent Dockerfile templates. (#1539)

These are only used for Beats and should have been deleted when the
agent migrated to its own repository.

* [Automation] Update elastic stack version to 8.6.0-f20b7179 for testing (#1692)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* [Automation] Update go release version to 1.18.8 (#1691)

Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>

* Cleanup merge.

* Order the outputs in component model so result is always the same order.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Co-authored-by: apmmachine <58790750+apmmachine@users.noreply.github.com>
Co-authored-by: apmmachine <infra-root-apmmachine@elastic.co>
Co-authored-by: Pier-Hugues Pellerin <phpellerin@gmail.com>
Co-authored-by: Denis Rechkunov <denis.rechkunov@elastic.co>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Co-authored-by: Aleksandr Maus <aleksandr.maus@elastic.co>
Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
Co-authored-by: Anderson Queiroz <anderson.queiroz@elastic.co>
Co-authored-by: Daniel Araujo Almeida <daniel-almeida@users.noreply.github.com>
Co-authored-by: Mariana Dima <mariana@elastic.co>
Co-authored-by: ofiriro3 <ofiriro3@Gmail.com>
Co-authored-by: Julien Lind <julien.lind@elastic.co>
Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co>
Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
Co-authored-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Co-authored-by: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
Co-authored-by: Andrew Cholakian <andrewvc@elastic.co>
Co-authored-by: Yash Tewari <yashtewari1996@gmail.com>
Co-authored-by: Quentin Pradet <quentin.pradet@elastic.co>
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Co-authored-by: Julien Mailleret <8582351+jmlrt@users.noreply.github.com>
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
Co-authored-by: Chris Mark <chrismarkou92@gmail.com>
Co-authored-by: apmmachine <infra-root+apmmachine@elastic.co>
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Kyle Pollich <kyle.pollich@elastic.co>
@blakerouse blakerouse added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Nov 9, 2022
@blakerouse blakerouse requested a review from a team as a code owner November 9, 2022 16:16
@blakerouse blakerouse self-assigned this Nov 9, 2022
@blakerouse blakerouse requested review from aleksmaus and michalpristas and removed request for a team November 9, 2022 16:16
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2022

This pull request does not have a backport label. Could you fix it @blakerouse? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Nov 9, 2022
@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-09T16:16:31.073+0000

  • Duration: 6 min 0 sec

Steps errors 1

Expand to view the steps failures

check
  • Took 0 min 19 sec . View more details here
  • Description: make check-ci

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@blakerouse blakerouse merged commit e7419dd into main Nov 9, 2022
@blakerouse blakerouse deleted the feature-arch-v2 branch November 9, 2022 16:42
@blakerouse blakerouse linked an issue Nov 9, 2022 that may be closed by this pull request
4 tasks
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-09T16:34:41.292+0000

  • Duration: 47 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 4481
Skipped 13
Total 4494

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.305% (58/59) 👍 1.008
Files 71.066% (140/197) 👍 1.936
Classes 70.557% (266/377) 👍 1.326
Methods 54.834% (794/1448) 👍 1.581
Lines 40.302% (8575/21277) 👍 0.994
Conditionals 100.0% (0/0) 💚

rseldner added a commit to elastic/ingest-docs that referenced this pull request Oct 27, 2023
Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue: 
#175

Related changes:
elastic/elastic-agent#1701
kilfoyle added a commit to elastic/ingest-docs that referenced this pull request Nov 14, 2023
…in 8.6.0 (#631)

* Update install-layout.asciidoc

Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue: 
#175

Related changes:
elastic/elastic-agent#1701

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
mergify bot pushed a commit to elastic/ingest-docs that referenced this pull request Nov 14, 2023
…in 8.6.0 (#631)

* Update install-layout.asciidoc

Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue:
#175

Related changes:
elastic/elastic-agent#1701

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 4fd3a33)
kilfoyle pushed a commit to elastic/ingest-docs that referenced this pull request Nov 14, 2023
…in 8.6.0 (#631) (#683)

* Update install-layout.asciidoc

Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue:
#175

Related changes:
elastic/elastic-agent#1701

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

* Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 4fd3a33)

Co-authored-by: Roberto Seldner <rseldner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge feature-arch-v2 into main
7 participants