Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(theme): add tests for mergeWithDefaultTheme #73

Merged
merged 2 commits into from Feb 21, 2019

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Feb 20, 2019

fix #59

It also fix 2 possible mutations on the default theme

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

  • [ ] This was checked for cross-browser compatibility, including a check against IE11
  • [ ] Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios
  • Each commit follows the convention

@codecov-io
Copy link

codecov-io commented Feb 20, 2019

Codecov Report

Merging #73 into master will increase coverage by 2.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   73.62%   75.82%   +2.19%     
==========================================
  Files          28       29       +1     
  Lines        1183     1183              
  Branches      217      215       -2     
==========================================
+ Hits          871      897      +26     
+ Misses        297      271      -26     
  Partials       15       15
Impacted Files Coverage Δ
src/lib/themes/theme.ts 100% <100%> (+89.65%) ⬆️
src/lib/themes/dark_theme.ts 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61729ed...3adccfc. Read the comment docs.

Copy link
Contributor

@emmacunningham emmacunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran test locally & code LGTM (hooray for increasing test coverage!)

@markov00 markov00 merged commit e82640d into elastic:master Feb 21, 2019
@markov00
Copy link
Member Author

markov00 commented Mar 6, 2019

🎉 This PR is included in version 2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Mar 6, 2019
@markov00 markov00 deleted the add-test-theme branch April 16, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Issue released publicly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for theme merge function
3 participants