From 936c741f788d46ddb496b15d54acb46a6578a5e8 Mon Sep 17 00:00:00 2001 From: Jaime Soriano Pastor Date: Fri, 23 Feb 2024 21:14:52 +0100 Subject: [PATCH 1/2] Make flag --benchmark mandatory in system benchmarks --- cmd/benchmark.go | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/benchmark.go b/cmd/benchmark.go index 4364ebaab9..0393511e85 100644 --- a/cmd/benchmark.go +++ b/cmd/benchmark.go @@ -533,6 +533,7 @@ func getSystemCommand() *cobra.Command { cmd.Flags().DurationP(cobraext.BenchMetricsIntervalFlagName, "", time.Second, cobraext.BenchMetricsIntervalFlagDescription) cmd.Flags().DurationP(cobraext.DeferCleanupFlagName, "", 0, cobraext.DeferCleanupFlagDescription) cmd.Flags().String(cobraext.VariantFlagName, "", cobraext.VariantFlagDescription) + cmd.MarkFlagRequired(cobraext.BenchNameFlagName) return cmd } From 4e489b3c8cd7ca8effbd60f6ae4f28fe06e60fae Mon Sep 17 00:00:00 2001 From: Jaime Soriano Pastor Date: Mon, 26 Feb 2024 11:11:04 +0100 Subject: [PATCH 2/2] Mark benchmark flag as required also in rally benchmark --- cmd/benchmark.go | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/benchmark.go b/cmd/benchmark.go index 0393511e85..9675e37858 100644 --- a/cmd/benchmark.go +++ b/cmd/benchmark.go @@ -244,6 +244,7 @@ func getRallyCommand() *cobra.Command { cmd.Flags().BoolP(cobraext.BenchCorpusRallyDryRunFlagName, "", false, cobraext.BenchCorpusRallyDryRunFlagDescription) cmd.Flags().StringP(cobraext.BenchCorpusRallyUseCorpusAtPathFlagName, "", "", cobraext.BenchCorpusRallyUseCorpusAtPathFlagDescription) cmd.Flags().StringP(cobraext.BenchCorpusRallyPackageFromRegistryFlagName, "", "", cobraext.BenchCorpusRallyPackageFromRegistryFlagDescription) + cmd.MarkFlagRequired(cobraext.BenchNameFlagName) return cmd }