Update go to 1.19.1

.go-version

@@ -1 +1 @@
-1.17.6
+1.19.1

Makefile

@@ -28,7 +28,7 @@ licenser:
 	go run github.com/elastic/go-licenser -license Elastic
 
 gomod:
-	go mod tidy -go=1.16 && go mod tidy -go=1.17
+	go mod tidy
 
 update-readme:
 	cd tools/readme; go run main.go

cmd/changelog.go

@@ -5,7 +5,7 @@
 package cmd
 
 import (
-	"io/ioutil"
+	"os"
 	"path/filepath"
 
 	"github.com/Masterminds/semver"
@@ -145,7 +145,7 @@ func changelogCmdVersion(nextMode, packageRoot string) (*semver.Version, error)
 // trying to conserve original format and comments.
 func patchChangelogFile(packageRoot string, patch changelog.Revision) error {
 	changelogPath := filepath.Join(packageRoot, changelog.PackageChangelogFile)
-	d, err := ioutil.ReadFile(changelogPath)
+	d, err := os.ReadFile(changelogPath)
 	if err != nil {
 		return err
 	}
@@ -155,12 +155,12 @@ func patchChangelogFile(packageRoot string, patch changelog.Revision) error {
 		return err
 	}
 
-	return ioutil.WriteFile(changelogPath, d, 0644)
+	return os.WriteFile(changelogPath, d, 0644)
 }
 
 func setManifestVersion(packageRoot string, version string) error {
 	manifestPath := filepath.Join(packageRoot, packages.PackageManifestFile)
-	d, err := ioutil.ReadFile(manifestPath)
+	d, err := os.ReadFile(manifestPath)
 	if err != nil {
 		return err
 	}
@@ -170,5 +170,5 @@ func setManifestVersion(packageRoot string, version string) error {
 		return err
 	}
 
-	return ioutil.WriteFile(manifestPath, d, 0644)
+	return os.WriteFile(manifestPath, d, 0644)
 }

cmd/status_test.go

@@ -7,7 +7,7 @@ package cmd
 import (
 	"bytes"
 	"flag"
-	"io/ioutil"
+	"os"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -121,11 +121,11 @@ func TestStatusFormatAndPrint(t *testing.T) {
 
 func assertOutputWithFile(t *testing.T, path string, out string) {
 	if *generateFlag {
-		err := ioutil.WriteFile(path, []byte(out), 0644)
+		err := os.WriteFile(path, []byte(out), 0644)
 		require.NoError(t, err)
 	}
 
-	d, err := ioutil.ReadFile(path)
+	d, err := os.ReadFile(path)
 	require.NoError(t, err)
 
 	assert.Equal(t, string(d), out)

go.mod

@@ -1,6 +1,6 @@
 module github.com/elastic/elastic-package
 
-go 1.17
+go 1.19
 
 require (
 	github.com/AlecAivazis/survey/v2 v2.3.5

internal/certs/certs_test.go

@@ -10,7 +10,7 @@ import (
 	"crypto/tls"
 	"crypto/x509"
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net"
 	"net/http"
 	"os/exec"
@@ -114,7 +114,7 @@ func testTLSClient(t *testing.T, root *Certificate, commonName, address string)
 	resp, err := client.Get("https://" + commonName)
 	require.NoError(t, err)
 	defer resp.Body.Close()
-	d, _ := ioutil.ReadAll(resp.Body)
+	d, _ := io.ReadAll(resp.Body)
 	assert.Equal(t, http.StatusOK, resp.StatusCode)
 	assert.Equal(t, "ok", string(d))
 

internal/certs/pool.go

@@ -8,7 +8,7 @@ import (
 	"crypto/x509"
 	"encoding/pem"
 	"fmt"
-	"io/ioutil"
+	"os"
 )
 
 // PoolWithCACertificate returns a new pool that includes the CA certificate
@@ -37,7 +37,7 @@ func SystemPoolWithCACertificate(path string) (*x509.CertPool, error) {
 }
 
 func addCACertificateToPool(pool *x509.CertPool, path string) error {
-	d, err := ioutil.ReadFile(path)
+	d, err := os.ReadFile(path)
 	if err != nil {
 		return fmt.Errorf("failed to read certificate in %q: %w", path, err)
 	}

internal/dump/componenttemplates.go

@@ -8,7 +8,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 
 	"github.com/elastic/elastic-package/internal/elasticsearch"
 )
@@ -71,7 +71,7 @@ func getComponentTemplatesByName(ctx context.Context, api *elasticsearch.API, na
 	}
 	defer resp.Body.Close()
 
-	d, err := ioutil.ReadAll(resp.Body)
+	d, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return nil, fmt.Errorf("failed to read response body: %w", err)
 	}

internal/dump/ilmpolicies.go

@@ -8,7 +8,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 
 	"github.com/elastic/elastic-package/internal/elasticsearch"
 )
@@ -57,7 +57,7 @@ func getILMPolicyByName(ctx context.Context, api *elasticsearch.API, policy stri
 	}
 	defer resp.Body.Close()
 
-	d, err := ioutil.ReadAll(resp.Body)
+	d, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return nil, fmt.Errorf("failed to read response body: %w", err)
 	}

internal/dump/indextemplates.go

@@ -8,7 +8,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 
 	"github.com/elastic/elastic-package/internal/common"
 	"github.com/elastic/elastic-package/internal/elasticsearch"
@@ -77,7 +77,7 @@ func getIndexTemplatesForPackage(ctx context.Context, api *elasticsearch.API, pa
 	}
 	defer resp.Body.Close()
 
-	d, err := ioutil.ReadAll(resp.Body)
+	d, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return nil, fmt.Errorf("failed to read response body: %w", err)
 	}

internal/dump/ingestpipelines.go

@@ -8,7 +8,7 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
+	"io"
 
 	"github.com/elastic/elastic-package/internal/common"
 	"github.com/elastic/elastic-package/internal/elasticsearch"
@@ -71,7 +71,7 @@ func getIngestPipelineByID(ctx context.Context, api *elasticsearch.API, id strin
 	}
 	defer resp.Body.Close()
 
-	d, err := ioutil.ReadAll(resp.Body)
+	d, err := io.ReadAll(resp.Body)
 	if err != nil {
 		return nil, fmt.Errorf("failed to read response body: %w", err)
 	}

internal/dump/installedobjects_test.go

@@ -9,7 +9,6 @@ import (
 	"encoding/json"
 	"errors"
 	"io/fs"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"testing"
@@ -164,7 +163,7 @@ func assertEqualDumps(t *testing.T, expectedDir, resultDir string) {
 func assertEquivalentJSON(t *testing.T, expectedPath, foundPath string) {
 	t.Helper()
 	readJSON := func(p string) map[string]interface{} {
-		d, err := ioutil.ReadFile(p)
+		d, err := os.ReadFile(p)
 		require.NoError(t, err)
 		var o map[string]interface{}
 		err = json.Unmarshal(d, &o)

internal/dump/json.go

@@ -8,7 +8,6 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 )
@@ -27,7 +26,7 @@ func dumpJSONResource(dir string, object DumpableJSONResource) error {
 		return fmt.Errorf("failed to format JSON object: %w", err)
 	}
 	path := filepath.Join(dir, object.Name()+".json")
-	err = ioutil.WriteFile(path, formatted, 0644)
+	err = os.WriteFile(path, formatted, 0644)
 	if err != nil {
 		return fmt.Errorf("failed to dump object to file: %w", err)
 	}

internal/elasticsearch/client_test.go

@@ -8,9 +8,9 @@ import (
 	"bytes"
 	"crypto/x509"
 	"encoding/pem"
-	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
+	"os"
 	"path/filepath"
 	"testing"
 
@@ -59,7 +59,7 @@ func writeCACertFile(t *testing.T, cert *x509.Certificate) string {
 	require.NoError(t, err)
 
 	caCertFile := filepath.Join(t.TempDir(), "ca.pem")
-	err = ioutil.WriteFile(caCertFile, d.Bytes(), 0644)
+	err = os.WriteFile(caCertFile, d.Bytes(), 0644)
 	require.NoError(t, err)
 
 	return caCertFile

internal/files/sign.go

@@ -6,7 +6,6 @@ package files
 
 import (
 	"fmt"
-	"io/ioutil"
 	"os"
 
 	"github.com/ProtonMail/gopenpgp/v2/armor"
@@ -54,7 +53,7 @@ func VerifySignerConfiguration() error {
 func Sign(targetFile string, options SignOptions) error {
 	signerPrivateKeyfile := os.Getenv(signerPrivateKeyfileEnv)
 	logger.Debugf("Read signer private keyfile: %s", signerPrivateKeyfile)
-	signerPrivateKey, err := ioutil.ReadFile(signerPrivateKeyfile)
+	signerPrivateKey, err := os.ReadFile(signerPrivateKeyfile)
 	if err != nil {
 		return errors.Wrapf(err, "can't read the signer private keyfile (path: %s)", signerPrivateKeyfile)
 	}
@@ -97,7 +96,7 @@ func Sign(targetFile string, options SignOptions) error {
 
 	logger.Debug("Signature generated for the target file, writing the .sig file")
 	targetSigFile := targetFile + ".sig"
-	err = ioutil.WriteFile(targetSigFile, []byte(armoredSignature), 0644)
+	err = os.WriteFile(targetSigFile, []byte(armoredSignature), 0644)
 	if err != nil {
 		return errors.Wrap(err, "can't write the signature file")
 	}

internal/kibana/client_test.go

@@ -9,9 +9,9 @@ import (
 	"crypto/x509"
 	"encoding/pem"
 	"fmt"
-	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
+	"os"
 	"path/filepath"
 	"testing"
 
@@ -60,7 +60,7 @@ func writeCACertFile(t *testing.T, cert *x509.Certificate) string {
 	require.NoError(t, err)
 
 	caCertFile := filepath.Join(t.TempDir(), "ca.pem")
-	err = ioutil.WriteFile(caCertFile, d.Bytes(), 0644)
+	err = os.WriteFile(caCertFile, d.Bytes(), 0644)
 	require.NoError(t, err)
 
 	return caCertFile

internal/packages/changelog/yaml_test.go

@@ -6,7 +6,6 @@ package changelog
 
 import (
 	"errors"
-	"io/ioutil"
 	"os"
 	"testing"
 
@@ -75,15 +74,15 @@ func TestPatchYAML(t *testing.T) {
 
 	for _, c := range cases {
 		t.Run(c.title, func(t *testing.T) {
-			d, err := ioutil.ReadFile(c.original)
+			d, err := os.ReadFile(c.original)
 			require.NoError(t, err)
 
 			result, err := PatchYAML(d, c.patch)
 			require.NoError(t, err)
 
-			expected, err := ioutil.ReadFile(c.expected)
+			expected, err := os.ReadFile(c.expected)
 			if errors.Is(err, os.ErrNotExist) {
-				err := ioutil.WriteFile(c.expected, result, 0644)
+				err := os.WriteFile(c.expected, result, 0644)
 				require.NoError(t, err)
 				t.Skip("file generated, run again")
 			}

internal/testrunner/runners/system/servicedeployer/compose.go

@@ -6,7 +6,6 @@ package servicedeployer
 
 import (
 	"fmt"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"time"
@@ -220,7 +219,7 @@ func writeServiceContainerLogs(serviceName string, content []byte) error {
 
 	containerLogsFilepath := filepath.Join(containerLogsDir, fmt.Sprintf("%s-%d.log", serviceName, time.Now().UnixNano()))
 	logger.Infof("Write container logs to file: %s", containerLogsFilepath)
-	err = ioutil.WriteFile(containerLogsFilepath, content, 0644)
+	err = os.WriteFile(containerLogsFilepath, content, 0644)
 	if err != nil {
 		return errors.Wrapf(err, "can't write container logs to file (path: %s)", containerLogsFilepath)
 	}

internal/testrunner/runners/system/servicedeployer/kubernetes.go

@@ -8,7 +8,6 @@ import (
 	"bytes"
 	_ "embed"
 	"encoding/base64"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"strings"
@@ -208,7 +207,7 @@ func readCACertBase64() (string, error) {
 		return "", errors.Errorf("%s not defined", stack.CACertificateEnv)
 	}
 
-	d, err := ioutil.ReadFile(caCertPath)
+	d, err := os.ReadFile(caCertPath)
 	if err != nil {
 		return "", err
 	}