Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add EsInputSplit.toString method which can be used for debugging #1144

Merged
merged 1 commit into from May 23, 2018

Conversation

@wankunde
Copy link
Contributor

commented Apr 29, 2018

  • I have signed the [Contributor License Agreement (CLA)[]

When we debug the mapreduce program, EsInputSplit's detail message will tell us what the map is doing.

@jbaiera

This comment has been minimized.

Copy link
Contributor

commented Apr 30, 2018

This LGTM, but it seems that the CLA is either not signed or hasn't updated yet. Could you double check that you have signed the CLA?

@jbaiera

This comment has been minimized.

Copy link
Contributor

commented May 7, 2018

Posting to see if CLA check is updated yet

@jbaiera

This comment has been minimized.

Copy link
Contributor

commented May 14, 2018

@wankunde Can you confirm if you've signed the CLA with the same email address used to author the git commits for this PR?

@karmi

This comment has been minimized.

Copy link
Member

commented May 23, 2018

Hi @wankunde, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@wankunde

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2018

@jbaiera I'm sorry, i have just signed the CLA,and got a license agreement.
2018-05-24 12 23 27

@karmi

This comment has been minimized.

Copy link
Member

commented May 23, 2018

@wankunde , all good now, thanks!

@wankunde

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2018

thank you all~~

@jbaiera

This comment has been minimized.

Copy link
Contributor

commented May 23, 2018

Awesome, thanks @wankunde @karmi

@jbaiera jbaiera merged commit 50564b5 into elastic:master May 23, 2018
2 checks passed
2 checks passed
CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jbaiera added a commit that referenced this pull request May 23, 2018
jbaiera added a commit that referenced this pull request May 23, 2018
jbaiera added a commit that referenced this pull request May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.