Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DateIndexFormatterTest #1232

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@viirya
Copy link
Contributor

commented Dec 26, 2018

Now pulling the code and doing ./gradlew test fails DateIndexFormatterTest:

org.elasticsearch.hadoop.serialization.field.DateIndexFormatterTest > testTimeYMDFormat FAILED
    java.lang.AssertionError at DateIndexFormatterTest.java:34

1348 tests completed, 1 failed, 470 skipped

It is due to timezone difference. I think it is better to make the test passed no matter timezone.

@jbaiera

jbaiera approved these changes Jan 2, 2019

Copy link
Contributor

left a comment

LGTM, thanks for cleaning these up!

@jbaiera jbaiera merged commit 2e5e804 into elastic:master Jan 2, 2019

2 checks passed

CLA Commit author has signed the CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jbaiera jbaiera added the v7.0.0 label Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.