Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup httpProxy property #889

Merged
merged 1 commit into from Nov 4, 2016
Merged

Fix setup httpProxy property #889

merged 1 commit into from Nov 4, 2016

Conversation

wmellouli
Copy link
Contributor

@wmellouli wmellouli commented Nov 4, 2016

Issue description

We cannot disable the use of system Http proxy properties (http.proxyHost and http.proxyPort) using the property es.net.proxy.http.use.system.props. As a workaround, we have to use the https property es.net.proxy.https.use.system.props.

In line 410 of class org.elasticsearch.hadoop.cfg.Settings, we load HTTPS properties instead of HTTP properties:
org.elasticsearch.hadoop.cfg.Settings#Line410

See also: org.elasticsearch.hadoop.rest.commonshttp.CommonsHttpTransport#Line264

Steps to reproduce

Set an http proxy in your system, and then try to disable the use of system Http proxy properties:

es.net.proxy.http.use.system.props = false

this property should not have an effect.

As a workaround, when you use the https property instead:

es.net.proxy.https.use.system.props = false

now, it should work.

@jbaiera
Copy link
Member

jbaiera commented Nov 4, 2016

Thanks for opening a PR @wmellouli, but could you update the post with a synopsis for the changes?

@wmellouli
Copy link
Contributor Author

@jbaiera I added the Issue description and steps to reproduce

@jbaiera
Copy link
Member

jbaiera commented Nov 4, 2016

@wmellouli Awesome, thanks. The change looks good to me. Good find.

@jbaiera jbaiera merged commit b8784b4 into elastic:master Nov 4, 2016
jbaiera pushed a commit that referenced this pull request Nov 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants