From 2d3d19433acc8ba5dcc6bec3ebdef76fbea16fe9 Mon Sep 17 00:00:00 2001 From: Laura Trotta Date: Mon, 20 Oct 2025 17:17:06 +0200 Subject: [PATCH 1/2] set db.operation.name and db.system.name at span build time --- .../instrumentation/OpenTelemetryForElasticsearch.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/java-client/src/main/java/co/elastic/clients/transport/instrumentation/OpenTelemetryForElasticsearch.java b/java-client/src/main/java/co/elastic/clients/transport/instrumentation/OpenTelemetryForElasticsearch.java index ec8afb223..e0754d513 100644 --- a/java-client/src/main/java/co/elastic/clients/transport/instrumentation/OpenTelemetryForElasticsearch.java +++ b/java-client/src/main/java/co/elastic/clients/transport/instrumentation/OpenTelemetryForElasticsearch.java @@ -27,6 +27,7 @@ import io.opentelemetry.api.OpenTelemetry; import io.opentelemetry.api.common.AttributeKey; import io.opentelemetry.api.trace.Span; +import io.opentelemetry.api.trace.SpanBuilder; import io.opentelemetry.api.trace.SpanKind; import io.opentelemetry.api.trace.StatusCode; import io.opentelemetry.api.trace.Tracer; @@ -185,10 +186,13 @@ OTelContext(TRequest request, Endpoint endpoint) { } this.endpointId = endpointId; - span = tracer.spanBuilder(endpointId).setSpanKind(SpanKind.CLIENT).startSpan(); + span = tracer.spanBuilder(endpointId).setSpanKind(SpanKind.CLIENT) + .setAttribute(ATTR_DB_SYSTEM, "elasticsearch") + .setAttribute(ATTR_DB_OPERATION, endpointId) + .startSpan(); + if (span.isRecording()) { - span.setAttribute(ATTR_DB_SYSTEM, "elasticsearch"); - span.setAttribute(ATTR_DB_OPERATION, endpointId); + span.setAttribute(ATTR_HTTP_REQUEST_METHOD, endpoint.method(request)); for (Map.Entry pathParamEntry : endpoint.pathParameters(request).entrySet()) { From 82c55c38a291b12a9c16a7ea3070f2458942cc66 Mon Sep 17 00:00:00 2001 From: Laura Trotta Date: Mon, 20 Oct 2025 17:19:42 +0200 Subject: [PATCH 2/2] clean --- .../transport/instrumentation/OpenTelemetryForElasticsearch.java | 1 - 1 file changed, 1 deletion(-) diff --git a/java-client/src/main/java/co/elastic/clients/transport/instrumentation/OpenTelemetryForElasticsearch.java b/java-client/src/main/java/co/elastic/clients/transport/instrumentation/OpenTelemetryForElasticsearch.java index e0754d513..6e56e43d8 100644 --- a/java-client/src/main/java/co/elastic/clients/transport/instrumentation/OpenTelemetryForElasticsearch.java +++ b/java-client/src/main/java/co/elastic/clients/transport/instrumentation/OpenTelemetryForElasticsearch.java @@ -27,7 +27,6 @@ import io.opentelemetry.api.OpenTelemetry; import io.opentelemetry.api.common.AttributeKey; import io.opentelemetry.api.trace.Span; -import io.opentelemetry.api.trace.SpanBuilder; import io.opentelemetry.api.trace.SpanKind; import io.opentelemetry.api.trace.StatusCode; import io.opentelemetry.api.trace.Tracer;