Skip to content

Conversation

@ugosan
Copy link
Contributor

@ugosan ugosan commented Oct 3, 2025

@gitnotebooks
Copy link

gitnotebooks bot commented Oct 3, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/493

@justincastilla
Copy link
Contributor

@ugosan added some style suggestions to match searchlabs notebook conventions. Also can you use the elasticsearch client instead of requests for this, please?

Other than that, looks pretty good!

ugosan and others added 5 commits October 6, 2025 09:10
…s/notebook.ipynb

Co-authored-by: Justin Castilla <59704472+justincastilla@users.noreply.github.com>
Co-authored-by: Justin Castilla <59704472+justincastilla@users.noreply.github.com>
@ugosan
Copy link
Contributor Author

ugosan commented Oct 6, 2025

thanks @justincastilla , updated!

@justincastilla
Copy link
Contributor

@ugosan Just one last minor change and it's good to merge!

…s/notebook.ipynb

Co-authored-by: Justin Castilla <59704472+justincastilla@users.noreply.github.com>
@ugosan
Copy link
Contributor Author

ugosan commented Oct 6, 2025

Thanks @justincastilla , I have also made the changes in the document to reflect the latest code state

Copy link
Contributor

@justincastilla justincastilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justincastilla justincastilla merged commit f14e078 into main Oct 7, 2025
2 checks passed
@justincastilla justincastilla deleted the mistral-chat-completions branch October 7, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants