New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async requests are not really async #189

Closed
dorony opened this Issue Mar 6, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@dorony

dorony commented Mar 6, 2013

Hi,
I noticed that SearchAsync is making synchronous calls in reality.
I think the fault might be with this code (DoAsyncRequest):

if (tcs.Task != null && tcs.Task.Result != null)

As it accesses the Task's Result, we wait for the task to complete...

Mpdreamz added a commit that referenced this issue Mar 7, 2013

@Mpdreamz

This comment has been minimized.

Show comment
Hide comment
@Mpdreamz

Mpdreamz Mar 7, 2013

Member

Thanks this is now fixed in 0.9.20.0!

I also wrote a lengthy blog post what went wrong, and the new fixes:
http://localghost.io/articles/oss-development,-a-continuous-lesson-in-humility-2013-03-07/

Thanks a ton for pointing it out @dorony

Member

Mpdreamz commented Mar 7, 2013

Thanks this is now fixed in 0.9.20.0!

I also wrote a lengthy blog post what went wrong, and the new fixes:
http://localghost.io/articles/oss-development,-a-continuous-lesson-in-humility-2013-03-07/

Thanks a ton for pointing it out @dorony

@Mpdreamz Mpdreamz closed this Mar 7, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment