Async requests are not really async #189

dorony opened this Issue Mar 6, 2013 · 1 comment


None yet

2 participants

dorony commented Mar 6, 2013

I noticed that SearchAsync is making synchronous calls in reality.
I think the fault might be with this code (DoAsyncRequest):

if (tcs.Task != null && tcs.Task.Result != null)

As it accesses the Task's Result, we wait for the task to complete...

Mpdreamz commented Mar 7, 2013

Thanks this is now fixed in!

I also wrote a lengthy blog post what went wrong, and the new fixes:,-a-continuous-lesson-in-humility-2013-03-07/

Thanks a ton for pointing it out @dorony

@Mpdreamz Mpdreamz closed this Mar 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment