New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added project for testing performance of HTTP & Thrift protocols #112

Merged
merged 1 commit into from Nov 11, 2012

Conversation

Projects
None yet
2 participants
@cocowalla
Contributor

cocowalla commented Oct 10, 2012

Related to issue #110

@cocowalla

This comment has been minimized.

Show comment
Hide comment
@cocowalla

cocowalla Oct 10, 2012

Contributor

Note this includes an ugly hack in ElasticClient.GetNodeInfo (as a workaround for a bug in the Thrift connection), so I guess you don't want to merge it into the master branch :)

Contributor

cocowalla commented Oct 10, 2012

Note this includes an ugly hack in ElasticClient.GetNodeInfo (as a workaround for a bug in the Thrift connection), so I guess you don't want to merge it into the master branch :)

@Mpdreamz Mpdreamz referenced this pull request Nov 2, 2012

Closed

Mono? #122

@Mpdreamz

This comment has been minimized.

Show comment
Hide comment
@Mpdreamz

Mpdreamz Nov 11, 2012

Member

@cocowalla i also had problems with GetNodeInfo but adhering to the chart found at

https://github.com/elasticsearch/elasticsearch-transport-thrift

and upgrading my 19.8 to 19.9 fixed any connection issues.

I'm now seeing identical body's in the thrift index but the http index has nice random body's on the messages. Investigating the cause of this now.

Member

Mpdreamz commented Nov 11, 2012

@cocowalla i also had problems with GetNodeInfo but adhering to the chart found at

https://github.com/elasticsearch/elasticsearch-transport-thrift

and upgrading my 19.8 to 19.9 fixed any connection issues.

I'm now seeing identical body's in the thrift index but the http index has nice random body's on the messages. Investigating the cause of this now.

@Mpdreamz

This comment has been minimized.

Show comment
Hide comment
@Mpdreamz

Mpdreamz Nov 11, 2012

Member

@cocowalla

I rewrote the ThriftConnection to use its own pooling (similar to how the default connection does it) and the tests to use the async overloads instead of wrapping the sync calls in tasks manually.

I'm seeing really impressive speedups using thrift!

HTTP: 12123 docs/s
Thrift: 17575 docs/s

Those are documents per second and on first inspection everything seems to be in working order.

Member

Mpdreamz commented Nov 11, 2012

@cocowalla

I rewrote the ThriftConnection to use its own pooling (similar to how the default connection does it) and the tests to use the async overloads instead of wrapping the sync calls in tasks manually.

I'm seeing really impressive speedups using thrift!

HTTP: 12123 docs/s
Thrift: 17575 docs/s

Those are documents per second and on first inspection everything seems to be in working order.

@Mpdreamz Mpdreamz merged commit f6063a8 into elastic:master Nov 11, 2012

@Mpdreamz

This comment has been minimized.

Show comment
Hide comment
@Mpdreamz

Mpdreamz Nov 11, 2012

Member

Thank you @cocowalla for bringing thrift back in to the picture and thank you @medcl for porting your thrift connection over to NEST 👍 👍

Member

Mpdreamz commented Nov 11, 2012

Thank you @cocowalla for bringing thrift back in to the picture and thank you @medcl for porting your thrift connection over to NEST 👍 👍

@Mpdreamz

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment