add store to timestamp field mapping #1533 #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR @KodrAus ! I left one minor comment. We have a few unit tests for the timestamp field. It would be great if you could include the Also, would you mind signing the CLA? |
Author
|
I've signed the CLA. Thanks for linking to the unit tests, I'll make the changes and add tests |
KodrAus
changed the title
KodrAus
changed the title
KodrAus
changed the title
Contributor
|
Excellent, thank you! One other nitpick I just noticed ^^. |
Author
|
How's this looking now? It should be verifying that store is not serialized in |
Contributor
|
LGTM! Thanks again @KodrAus |
gmarz
added a commit
that referenced
this pull request
Aug 25, 2015
add store to timestamp field mapping #1533
Author
|
No worries! I'm trying to get more involved in the ES community, since I've been mooching off it for years |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1533 Any unit tests to implement?