From 1e5277d49d71e45db44b3ad85430e14a70ed1d5c Mon Sep 17 00:00:00 2001 From: Jonathan Adamit Date: Thu, 10 Dec 2015 21:34:13 +0200 Subject: [PATCH 1/2] PingTimeout does not use a time unit. --- src/Elasticsearch.Net/Transport/Pipeline/RequestPipeline.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Elasticsearch.Net/Transport/Pipeline/RequestPipeline.cs b/src/Elasticsearch.Net/Transport/Pipeline/RequestPipeline.cs index 1028aa52685..95bbe70e663 100644 --- a/src/Elasticsearch.Net/Transport/Pipeline/RequestPipeline.cs +++ b/src/Elasticsearch.Net/Transport/Pipeline/RequestPipeline.cs @@ -245,7 +245,7 @@ public async Task PingAsync(Node node) } } - private string SniffPath => "_nodes/_all/settings?flat_settings&timeout=" + this.PingTimeout; + private string SniffPath => "_nodes/_all/settings?flat_settings&timeout=" + this.PingTimeout.TotalMilliseconds + "ms"; public IEnumerable SniffNodes => this._connectionPool.CreateView().ToList().OrderBy(n => n.MasterEligable ? n.Uri.Port : int.MaxValue); From cf07ce1628d9da8d0b6bf55a6eb96c155e044777 Mon Sep 17 00:00:00 2001 From: Jonathan Adamit Date: Sun, 13 Dec 2015 16:35:19 +0200 Subject: [PATCH 2/2] settings now contains a string. --- src/Elasticsearch.Net/Transport/Sniff/SniffResponse.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Elasticsearch.Net/Transport/Sniff/SniffResponse.cs b/src/Elasticsearch.Net/Transport/Sniff/SniffResponse.cs index 9c4545854a2..15076a5deec 100644 --- a/src/Elasticsearch.Net/Transport/Sniff/SniffResponse.cs +++ b/src/Elasticsearch.Net/Transport/Sniff/SniffResponse.cs @@ -37,8 +37,8 @@ internal class SniffNode public string build { get; set; } public IDictionary settings { get; set; } - internal bool MasterEligable => !((this.settings?.ContainsKey("node.master")).GetValueOrDefault(false) && ((bool)this.settings["node.master"]) == false); - internal bool HoldsData => !((this.settings?.ContainsKey("node.data")).GetValueOrDefault(false) && ((bool)this.settings["node.data"]) == false); + internal bool MasterEligable => !((this.settings?.ContainsKey("node.master")).GetValueOrDefault(false) && Convert.ToBoolean(this.settings["node.master"]) == false); + internal bool HoldsData => !((this.settings?.ContainsKey("node.data")).GetValueOrDefault(false) && Convert.ToBoolean(this.settings["node.data"]) == false); } }