Support serialization of geo shapes on documents #3208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think the geo shape support should be revisited in 7.x. For example,
|
codebrain
approved these changes
Apr 24, 2018
Contributor
codebrain
left a comment
codebrain
left a comment
There was a problem hiding this comment.
LGTM - a minor observation - are we going to allow geoshapes on documents?
| typeof(Attachment), | ||
| typeof(ILazyDocument) | ||
| typeof(ILazyDocument), | ||
| typeof(GeoCoordinate) |
Contributor
There was a problem hiding this comment.
IGeoShape as well as IGeometryCollection ?
Contributor
Author
There was a problem hiding this comment.
Handled on lines 56 and 57 below. It's possible that a user could specify any type that implements IGeoShape e.g. IPolygonGeoShape, so json conversion should check if IGeoShape is assignable from the type.
| } | ||
|
|
||
| // adapted from https://gis.stackexchange.com/a/103465/30046 | ||
| private static IEnumerable<GeoCoordinate> GeneratePolygonCoordinates(Faker p, GeoCoordinate centroid, double maxDistance = 0.0002) |
This commit changes GeometryCollection to implement IGeoShape, to allow a document to have an IGeoShape member and accept a GeometryCollection. IGeoShape.Type is implemented explicitly so that the existing Type member continues to be the implicit implementation of IGeometryCollection. The ideal scenario would have been for IGeometryCollection to implement IGeoShape however this would break backwards binary compatibility, since both interfaces have a Type member.
russcam
added a commit
that referenced
this pull request
Apr 26, 2018
* Support serialization of geo shapes on documents Fixes #3100 Fixes #3096 * GeometryCollection implements IGeoShape This commit changes GeometryCollection to implement IGeoShape, to allow a document to have an IGeoShape member and accept a GeometryCollection. IGeoShape.Type is implemented explicitly so that the existing Type member continues to be the implicit implementation of IGeometryCollection. The ideal scenario would have been for IGeometryCollection to implement IGeoShape however this would break backwards binary compatibility, since both interfaces have a Type member. (cherry picked from commit 96c0d4d)
russcam
added a commit
that referenced
this pull request
Apr 26, 2018
* Support serialization of geo shapes on documents Fixes #3100 Fixes #3096 * GeometryCollection implements IGeoShape This commit changes GeometryCollection to implement IGeoShape, to allow a document to have an IGeoShape member and accept a GeometryCollection. IGeoShape.Type is implemented explicitly so that the existing Type member continues to be the implicit implementation of IGeometryCollection. The ideal scenario would have been for IGeometryCollection to implement IGeoShape however this would break backwards binary compatibility, since both interfaces have a Type member. (cherry picked from commit 96c0d4d) This commit includes changes from PR #3214, which were required to address incorrect serialization introduced in 6.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3100
Fixes #3096