From 0075d98f7687c2d7596ac746977a28c73cc65cff Mon Sep 17 00:00:00 2001 From: Stuart Cam Date: Wed, 13 Mar 2019 17:54:10 +1100 Subject: [PATCH 1/2] Throw a parsing exception when boost is set in span_or query, Relates to elastic/elasticsearch#28390 and elastic/elasticsearch#34112 --- src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs b/src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs index 76d22ced999..9077eddb62b 100644 --- a/src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs +++ b/src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs @@ -9,6 +9,7 @@ public interface IQuery /// Provides a boost to this query to influence its relevance score. /// For example, a query with a boost of 2 is twice as important as a query with a boost of 1, /// although the actual boost value that is applied undergoes normalization and internal optimization. + /// Setting a boost with a span_or query will throw a parsing exception on the server. /// [JsonProperty("boost")] double? Boost { get; set; } From cd9a0a7880d37493e37a496ffc6cad9e9c3707fe Mon Sep 17 00:00:00 2001 From: russcam Date: Mon, 18 Mar 2019 21:32:01 +1000 Subject: [PATCH 2/2] Update docs to use ISpanOrQuery --- src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs b/src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs index 9077eddb62b..9071bd23491 100644 --- a/src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs +++ b/src/Nest/QueryDsl/Abstractions/Query/QueryBase.cs @@ -9,8 +9,10 @@ public interface IQuery /// Provides a boost to this query to influence its relevance score. /// For example, a query with a boost of 2 is twice as important as a query with a boost of 1, /// although the actual boost value that is applied undergoes normalization and internal optimization. - /// Setting a boost with a span_or query will throw a parsing exception on the server. /// + /// + /// Setting a boost for an query will throw a parsing exception on the server. + /// [JsonProperty("boost")] double? Boost { get; set; }