Fix Query DSL usage tests #3804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds an IGeoShape property to Project called LocationShape, and always seeds it with a PointGeoShape. Rename Location to LocationPoint
This commit updates the GeoShapeFormatter to skip over the value of a field within JSON when it is not the type field. String allocations for property names are reduced by comparing fields to static byte fields.
This commit fixes the serialized ordering of lat lon values in the geo_shape query using an envelope, since server side validation only allows valid envelopes. Skip multi_point and circle geo_shape queries for now as both result in 400 error responses.
codebrain
approved these changes
Jun 7, 2019
Contributor
codebrain
left a comment
codebrain
left a comment
There was a problem hiding this comment.
LGTM - add to the meta ticket?
russcam
added a commit
that referenced
this pull request
Aug 7, 2019
This commit removes the lenient assertion within QueryDslUsagesTestsBase that allowed parsing exceptions in Elasticsearch to pass. This was a temporary solution whilst upgrading the client to work with Elasticsearch 7.x. Add an IGeoShape property to Project called LocationShape, and always seeds it with a PointGeoShape. Rename Location to LocationPoint Update the GeoShapeFormatter to skip over the value of a field within JSON when it is not the type field. String allocations for property names are reduced by comparing fields to static byte fields. Fix the serialized ordering of lat lon values in the geo_shape query using an envelope, since server side validation only allows valid envelopes. Skip multi_point and circle geo_shape queries for now as both result in 400 error responses. Do not set id when MoreLikeThis query input is a document GeoPolygon query requires a minimum of 3 coordinates
Mpdreamz
pushed a commit
that referenced
this pull request
Aug 9, 2019
* Send queries to cluster when running integration tests * Do not set _id and routing automatically (#3805) This commit updates LikeDocument so that _id and routing are not set when a document input is used. Routing is required in the MoreLikeThisFullDocumentQueryUsageTests because the Project type mapping requires routing, but this should not be the default. Fixes #3977 * Fix Query DSL usage tests (#3804) This commit removes the lenient assertion within QueryDslUsagesTestsBase that allowed parsing exceptions in Elasticsearch to pass. This was a temporary solution whilst upgrading the client to work with Elasticsearch 7.x. Add an IGeoShape property to Project called LocationShape, and always seeds it with a PointGeoShape. Rename Location to LocationPoint Update the GeoShapeFormatter to skip over the value of a field within JSON when it is not the type field. String allocations for property names are reduced by comparing fields to static byte fields. Fix the serialized ordering of lat lon values in the geo_shape query using an envelope, since server side validation only allows valid envelopes. Skip multi_point and circle geo_shape queries for now as both result in 400 error responses. Do not set id when MoreLikeThis query input is a document GeoPolygon query requires a minimum of 3 coordinates * Fix span query integration tests This commit fixes the span query integration tests. Fix namespaces. * Fix HasChild query integration tests This commit introduces a TypeRelation property of type RelationName and deprecates Type property. The property should be RelationName to correctly infer the relation. * Valid script in script query usage tests * Add routing value to More like this query * Use tag nested field in nested query usage tests * skip geo shape query tests on >=6.6.0 This commit skips geo shape queries for circles and multi_point above 6.6.0. These queries are not supported against BKD backed shapes * fix query_string query integration tests * Update docs * Assert AfterKey is not null only on >= 6.3.0 * Use static First Project property * Valid queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the lenient assertion within QueryDslUsagesTestsBase that allowed parsing exceptions in Elasticsearch to pass. This was a temporary solution whilst upgrading the client to work with Elasticsearch 7.x that must be removed before releasing to GA.
The remaining commits fix the remaining query usage tests that exhibited parsing tests. These were
geo shape query tests, which are now run against a new
geo_shapefield mapping onProject. Automapping will now also map anIGeoShapeproperty on a POCO as aGeoShapePropertyautomatically.more like this queries where the
_idfield was also being set when a document is provided for thelikeinput.