Remove default TypeNames and TypeName from IClrTypeMapping #3808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the defaultTypeNames mappings on ConnectionSettings as they are no longer used. The TypeName on IClrTypeMapping is also removed as it too is no longer used.
Contributor
Author
|
@Mpdreamz I remember you were talking about reintroducing deprecated paths last week which would mean reintroducing types. Is that still the plan? |
Mpdreamz
approved these changes
Jun 10, 2019
Member
|
It is but only for the low level client so that we can run the YAML tests on that. We can continue to scrub the remaining type bits from NEST. |
Member
|
LGTM, one small unit test failure though: https://dev.azure.com/azure3/elasticsearch-net/_build/results?buildId=752&view=ms.vss-test-web.build-test-results-tab&runId=6900&resultId=100110&paneView=debug |
Contributor
Author
This is fixed in #3805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the defaultTypeNames mappings on ConnectionSettings as they
are no longer used.
The TypeName on IClrTypeMapping is also removed as it too is no longer used.