Skip to content

Fix shape serialisation tests #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2019
Merged

Fix shape serialisation tests #4177

merged 1 commit into from
Oct 23, 2019

Conversation

@codebrain
Copy link
Contributor

@codebrain codebrain commented Oct 23, 2019

  • Remove circle from Shape tests
  • Change integration test setup to use Shape() instead of GeoShape()
  • Change default index for Shape types to be shapes

@codebrain
Remove circle from Shape tests, change integration test setup to use …
84cc9dc 
…Shape() instead of GeoShape(), change default index for Shape types.
@codebrain codebrain requested a review from russcam October 23, 2019 07:32
russcam
russcam approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@russcam russcam merged commit c1c95cf into 7.x Oct 23, 2019
@russcam
Copy link
Contributor

russcam commented Oct 23, 2019

ported to master

russcam pushed a commit that referenced this pull request Oct 23, 2019
@codebrain @russcam
Remove circle from Shape tests, change integration test setup to use …
6ec05ea 
…Shape() instead of GeoShape(), change default index for Shape types. (#4177)

(cherry picked from commit c1c95cf)
@Mpdreamz Mpdreamz deleted the fix/shape-serialisation-tests branch November 6, 2019 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@russcam russcam russcam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@codebrain @russcam