Skip to content

Conversation

@Tasteful
Copy link
Contributor

Resharper's UI for test are including the BaseParserTests even it a base-class and does not contains any tests.

@gmarz
Copy link
Contributor

gmarz commented Aug 14, 2014

Ah, good catch, it should indeed be abstract. BaseJsonTests too for that matter...

gmarz added a commit that referenced this pull request Aug 15, 2014
base-class should be abstract
@gmarz gmarz merged commit e9a25f5 into elastic:develop Aug 15, 2014
@Tasteful Tasteful deleted the abstract-base branch August 19, 2014 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants